fix(analytics): make service error-resilient, fix 5 failing tests

Wrap track/identify/groupIdentify in try/catch so the analytics service
never throws — callers no longer need defensive try/catch wrappers.
Update resilience tests to expect not.toThrow instead of toThrow.

Closes #3340

Author: PierreBrisorgueil

lib/services/analytics.js

@@ -37,7 +37,9 @@ const init = async () => {
  */
 const track = (distinctId, event, properties, groups) => {
   if (!client) return;
-  client.capture({ distinctId, event, properties, groups });
+  try {
+    client.capture({ distinctId, event, properties, groups });
+  } catch (_) { /* analytics must never break caller */ }
 };
 
 /**
@@ -48,7 +50,9 @@ const track = (distinctId, event, properties, groups) => {
  */
 const identify = (distinctId, properties) => {
   if (!client) return;
-  client.identify({ distinctId, properties });
+  try {
+    client.identify({ distinctId, properties });
+  } catch (_) { /* analytics must never break caller */ }
 };
 
 /**
@@ -60,7 +64,9 @@ const identify = (distinctId, properties) => {
  */
 const groupIdentify = (groupType, groupKey, properties) => {
   if (!client) return;
-  client.groupIdentify({ groupType, groupKey, properties });
+  try {
+    client.groupIdentify({ groupType, groupKey, properties });
+  } catch (_) { /* analytics must never break caller */ }
 };
 
 /**

lib/services/tests/analytics.service.resilience.unit.tests.js

@@ -41,31 +41,31 @@ describe('Analytics service resilience tests:', () => {
   });
 
   // ─────────────────────────────────────────────────────────────────────
-  // Error propagation — synchronous SDK failures
+  // Error resilience — synchronous SDK failures are swallowed
   // ─────────────────────────────────────────────────────────────────────
-  describe('synchronous SDK error propagation:', () => {
-    test('track should propagate when client.capture throws', () => {
+  describe('synchronous SDK error resilience:', () => {
+    test('track should not throw when client.capture throws', () => {
       mockPostHogInstance.capture.mockImplementation(() => {
         throw new Error('Capture error');
       });
 
-      expect(() => AnalyticsService.track('u1', 'evt')).toThrow('Capture error');
+      expect(() => AnalyticsService.track('u1', 'evt')).not.toThrow();
     });
 
-    test('identify should propagate when client.identify throws', () => {
+    test('identify should not throw when client.identify throws', () => {
       mockPostHogInstance.identify.mockImplementation(() => {
         throw new Error('Identify error');
       });
 
-      expect(() => AnalyticsService.identify('u1', {})).toThrow('Identify error');
+      expect(() => AnalyticsService.identify('u1', {})).not.toThrow();
     });
 
-    test('groupIdentify should propagate when client.groupIdentify throws', () => {
+    test('groupIdentify should not throw when client.groupIdentify throws', () => {
       mockPostHogInstance.groupIdentify.mockImplementation(() => {
         throw new Error('Group error');
       });
 
-      expect(() => AnalyticsService.groupIdentify('company', 'org', {})).toThrow('Group error');
+      expect(() => AnalyticsService.groupIdentify('company', 'org', {})).not.toThrow();
     });
   });