fix(organizations): handle falsy approval result, add missing @returns JSDoc

- Guard against falsy return from approveRequest with 409 response
- Add @returns {Promise<void>} to cleanupUser in e2e tests

Author: PierreBrisorgueil

modules/organizations/controllers/organizations.membershipRequest.controller.js

@@ -48,11 +48,14 @@ const listPending = async (req, res) => {
  * @description Endpoint to approve a pending membership request.
  * @param {Object} req - Express request object
  * @param {Object} res - Express response object
- * @returns {void}
+ * @returns {Promise<void>}
  */
 const approve = async (req, res) => {
   try {
     const membership = await MembershipService.approveRequest(req.membershipRequest);
+    if (!membership) {
+      return responses.error(res, 409, 'Conflict', 'Membership request could not be approved')();
+    }
     responses.success(res, 'membership request approved')(membership);
   } catch (err) {
     responses.error(res, 422, 'Unprocessable Entity', errors.getMessage(err))(err);

modules/organizations/tests/organizations.domainJoin.e2e.tests.js

@@ -28,6 +28,7 @@ describe('Organizations domain join E2E tests:', () => {
   /**
    * @description Clean up a user and their associated organizations/memberships.
    * @param {Object} user - The user object to clean up.
+   * @returns {Promise<void>}
    */
   const cleanupUser = async (user) => {
     if (!user) return;