Skip to content

Commit 696b351

Browse files
fix: address copilot review comments
- Fix prod script typo (extra 'node start' → 'node') - Remove extra spaces before punctuation in README, agent, feature skill - Fix broken markdown links in WIKI.md (remove incomplete URLs)
1 parent 365c5eb commit 696b351

5 files changed

Lines changed: 5 additions & 7 deletions

File tree

.claude/agents/stack-maintainer.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ You are the stack maintainer agent. Your role is to protect the mergeability and
1616
- **Secret leakage**: Check for accidentally committed secrets, tokens, or credentials
1717
- **Broad permissions**: Review permission changes for security risks
1818
- **Dependencies**: Flag suspicious or risky dependency additions
19-
- **Env vars**: Ensure sensitive config uses `DEVKIT_NODE_*` env vars , not hardcoded values
19+
- **Env vars**: Ensure sensitive config uses `DEVKIT_NODE_*` env vars, not hardcoded values
2020
- **Auth bypass**: Watch for changes that weaken JWT/Passport validation or policy middleware
2121

2222
### 3. Verify modularity

.claude/skills/feature/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,6 @@ npm test
7272

7373
## Notes
7474

75-
- Config is loaded from `config/` and overridable via `DEVKIT_NODE_*` env vars
75+
- Config is loaded from `config/` and overridable via `DEVKIT_NODE_*` env vars
7676
- Authentication is handled via Passport JWT middleware — don't reimplement
7777
- All policies must use `lib/middlewares/policy.js` patterns

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ GITHUB_TOKEN=xxx npm run release:auto # Semantic release (CI)
113113

114114
Configuration files live in `config/defaults/`. The `development.js` file is the base; other files in that folder override it.
115115

116-
Environment variables prefixed with `DEVKIT_NODE_` are merged on top . The variable path maps directly to the config object key:
116+
Environment variables prefixed with `DEVKIT_NODE_` are merged on top. The variable path maps directly to the config object key:
117117

118118
```bash
119119
DEVKIT_NODE_app_title='my app' # sets config.app.title

WIKI.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@ Welcome to the Node wiki! Here you will find various information about this repo
1515

1616

1717
* [Mindset and what we would like to create](https://github.com/pierreb-devkit)
18-
* [How to start a project and maintain updates from stacks](
19-
* [Global roadmap and ideas about stacks](https://github.com/orgs/pierreb-devkit/projects)
20-
* [How to contribute and help us](
18+
* [Global roadmap and ideas about stacks](https://github.com/orgs/pierreb-devkit/projects)
2119

2220
# Node WIKI
2321

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"scripts": {
2626
"start": "node server.js",
2727
"debug": "nodemon --inspect server.js",
28-
"prod": "cross-env NODE_ENV=production node start server.js --name=node",
28+
"prod": "cross-env NODE_ENV=production node server.js --name=node",
2929
"test": "cross-env NODE_ENV=test NODE_OPTIONS=--experimental-vm-modules jest --runInBand",
3030
"test:watch": "cross-env NODE_ENV=test NODE_OPTIONS=--experimental-vm-modules jest --watch --runInBand",
3131
"test:coverage": "cross-env NODE_ENV=test NODE_OPTIONS=--experimental-vm-modules jest --coverage --runInBand",

0 commit comments

Comments
 (0)