fix(billing): use active/trialing status allowlist in requireQuota middleware (#3280)

* fix(billing): use active/trialing status allowlist in requireQuota middleware

* fix(billing): extract activeStatuses constant and use test.each for inactive statuses

- Hoist activeStatuses to shared lib/constants.js to avoid duplication
  between requireQuota middleware and billing controller
- Collapse individual inactive-status test cases into test.each table
  for easier maintenance and extensibility

Author: PierreBrisorgueil

modules/billing/controllers/billing.controller.js

@@ -1,6 +1,7 @@
 /**
  * Module dependencies
  */
+import { activeStatuses } from '../lib/constants.js';
 import config from '../../../config/index.js';
 import responses from '../../../lib/helpers/responses.js';
 import BillingService from '../services/billing.service.js';
@@ -67,7 +68,6 @@ const getUsage = async (req, res) => {
   try {
     // Determine current plan via service layer
     const subscription = await BillingService.getSubscription(req.organization._id);
-    const activeStatuses = ['active', 'trialing'];
     const plan = (!subscription || !activeStatuses.includes(subscription.status)) ? 'free' : (subscription.plan || 'free');
 
     // Get usage counters (includes month field)

modules/billing/lib/constants.js

@@ -0,0 +1,5 @@
+/**
+ * Stripe subscription statuses that indicate an active subscription.
+ * Any status not in this list is treated as inactive (falls back to free plan).
+ */
+export const activeStatuses = ['active', 'trialing'];

modules/billing/middlewares/billing.requireQuota.js

@@ -4,6 +4,7 @@
 import SubscriptionRepository from '../repositories/billing.subscription.repository.js';
 import BillingUsageService from '../services/billing.usage.service.js';
 
+import { activeStatuses } from '../lib/constants.js';
 import config from '../../../config/index.js';
 import responses from '../../../lib/helpers/responses.js';
 
@@ -37,9 +38,9 @@ function requireQuota(resource, action) {
     }
 
     try {
-      // Determine current plan — default to free when no subscription or past_due
+      // Determine current plan — default to free when subscription is missing or inactive
       const subscription = await SubscriptionRepository.findByOrganization(req.organization._id);
-      const plan = (!subscription || subscription.status === 'past_due') ? 'free' : (subscription.plan || 'free');
+      const plan = (!subscription || !activeStatuses.includes(subscription.status)) ? 'free' : (subscription.plan || 'free');
 
       // Look up quota limit from config
       const quotas = config.billing?.quotas;

modules/billing/tests/billing.quota.unit.tests.js

@@ -117,19 +117,22 @@ describe('requireQuota middleware:', () => {
     }));
   });
 
-  test('should treat past_due subscription as free plan', async () => {
-    mockSubscriptionRepository.findByOrganization.mockResolvedValue({ plan: 'starter', status: 'past_due' });
-    mockBillingUsageService.get.mockResolvedValue({ counters: { 'scraps.create': 3 } });
-
-    await requireQuota('scraps', 'create')(req, res, next);
-
-    expect(next).not.toHaveBeenCalled();
-    expect(res.status).toHaveBeenCalledWith(429);
-    expect(res.json).toHaveBeenCalledWith(expect.objectContaining({
-      type: 'error',
-      code: 429,
-    }));
-  });
+  test.each(['past_due', 'canceled', 'unpaid', 'incomplete', 'incomplete_expired', 'paused'])(
+    'should treat %s subscription as free plan',
+    async (status) => {
+      mockSubscriptionRepository.findByOrganization.mockResolvedValue({ plan: 'starter', status });
+      mockBillingUsageService.get.mockResolvedValue({ counters: { 'scraps.create': 3 } });
+
+      await requireQuota('scraps', 'create')(req, res, next);
+
+      expect(next).not.toHaveBeenCalled();
+      expect(res.status).toHaveBeenCalledWith(429);
+      expect(res.json).toHaveBeenCalledWith(expect.objectContaining({
+        type: 'error',
+        code: 429,
+      }));
+    },
+  );
 
   test('should allow unlimited (Infinity) without checking usage', async () => {
     mockSubscriptionRepository.findByOrganization.mockResolvedValue({ plan: 'pro', status: 'active' });
@@ -173,6 +176,16 @@ describe('requireQuota middleware:', () => {
     expect(next).toHaveBeenCalled();
   });
 
+  test('should use subscription plan when status is trialing', async () => {
+    mockSubscriptionRepository.findByOrganization.mockResolvedValue({ plan: 'starter', status: 'trialing' });
+    mockBillingUsageService.get.mockResolvedValue({ counters: { 'scraps.create': 15 } });
+
+    await requireQuota('scraps', 'create')(req, res, next);
+
+    expect(next).toHaveBeenCalled();
+    expect(res.status).not.toHaveBeenCalled();
+  });
+
   test('should treat zero usage as under quota', async () => {
     mockSubscriptionRepository.findByOrganization.mockResolvedValue({ plan: 'free', status: 'active' });
     mockBillingUsageService.get.mockResolvedValue({ counters: {} });