test(analytics): comprehensive integration and edge-case tests (#3308)

* test(analytics): add comprehensive integration and edge-case tests

Express integration tests (supertest): middleware tracks real requests,
handles concurrent load, skips health routes, captures query strings.

Service resilience tests: SDK error propagation (sync + async),
post-shutdown no-op safety, double-shutdown idempotency, optional args.

Init wiring tests: module init calls AnalyticsService.init(), registers
middleware, sets up billing plan.changed listener with error isolation.

Feature-flag middleware edge cases: falsy _id variants (null, 0, empty),
ObjectId-like coercion, concurrent flag evaluations, 403 response shape.

Closes #3298

* fix(skills): align verify, feature, and pull-request with Vue conventions

* fix(analytics): update comprehensive tests for async init and query stripping

Author: PierreBrisorgueil

.claude/skills/feature/SKILL.md

@@ -77,7 +77,7 @@ If an action affects another user:
 - [ ] Error responses have user-friendly `description` field
 
 **Tests:**
-- [ ] Tests: add unit + integration tests. Add E2E (`*.e2e.tests.js`) only if the change affects a critical user flow (auth, org onboarding, invite/join).
+- [ ] Tests: add unit (`*.unit.tests.js`) + integration (`*.integration.tests.js`) tests. Add E2E (`*.e2e.tests.js`) only if the change affects a critical user flow (auth, org onboarding, invite/join).
 
 **Modularity:**
 - [ ] Isolated in ONE module (or justified)

.claude/skills/pull-request/SKILL.md

@@ -135,7 +135,7 @@ REPEAT:
   6. If actionable comments             → fix all, /verify, commit, push, reply, resolve, consecutive_zero=0, GOTO 1
   7. If non-actionable unresolved       → reply all explaining why, resolve all, consecutive_zero=0, GOTO 5
   8. If zero unresolved threads         → consecutive_zero++
-                                           if consecutive_zero >= 3 → check branch protection (see 6f), then STOP ✓
+                                           if consecutive_zero >= 3 (~9 min) → check branch protection (see 6f), then STOP ✓
                                            else GOTO 3
 ```
 
@@ -202,14 +202,15 @@ Wait 30s before watching CI (regular or force-push). Loop back to 6a. Never post
 
 ### 6f. Stop condition
 
-CI green **and** 2 consecutive passes with zero unresolved threads. Mergeable status is also checked after every CI pass (step 2b) — conflicts cause an early stop. Final branch protection check:
+CI green **and** 3 consecutive passes (~9 min of grace periods) with zero unresolved threads. Mergeable status is also checked after every CI pass (step 2b) — conflicts cause an early stop. Final branch protection check:
 
 ```bash
 gh pr view "$PR" --json reviewDecision,mergeable | jq '{reviewDecision, mergeable}'
 ```
 
 - `APPROVED` + `MERGEABLE` → **STOP ✓**
 - `REVIEW_REQUIRED` → report to user, stop
+- `CHANGES_REQUESTED` → report to user, stop
 - `BLOCKED` → report details to user
 
 **Safety limit:** 10 iterations max — report to user if still unresolved.