Skip to content

Commit 8a709b2

Browse files
fix(users): address third round of CodeRabbit review
- Return { deletedCount: 0 } instead of implicit undefined in remove() - Use $set operator in push() bulkWrite to prevent _id immutable field errors
1 parent e03232a commit 8a709b2

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

modules/users/repositories/users.repository.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ const update = (user) => {
9898
const remove = async (user) => {
9999
if (user && user.id && mongoose.Types.ObjectId.isValid(user.id)) return User.deleteOne({ _id: user.id }).exec();
100100
if (user && user.email) return User.deleteOne({ email: user.email }).exec();
101+
return { deletedCount: 0 };
101102
};
102103

103104
/**
@@ -129,7 +130,7 @@ const push = (users, filters) => {
129130
return {
130131
updateOne: {
131132
filter,
132-
update: user,
133+
update: { $set: user },
133134
upsert: true,
134135
},
135136
};

0 commit comments

Comments
 (0)