fix(home): address remaining review — JSDoc, CASL manage, log errors, cache isSet

- Add @returns {void} to readiness controller JSDoc
- Use can('manage', 'Readiness') matching standard CASL pattern
- Log readiness check failures at boot instead of swallowing
- Cache isSet(config.domain) to avoid duplicate calls

Author: PierreBrisorgueil

lib/app.js

@@ -112,8 +112,8 @@ const logConfiguration = async () => {
         const icon = c.status === 'ok' ? chalk.green('OK') : chalk.yellow('WARN');
         console.log(`  ${icon}  ${c.category.padEnd(12)} ${c.message}`);
       });
-    } catch (_err) {
-      // Non-blocking — readiness check failure should not prevent boot
+    } catch (err) {
+      console.log(chalk.yellow(`  SaaS readiness check failed: ${err.message}`));
     }
   }
 };

modules/home/controllers/home.controller.js

@@ -97,9 +97,10 @@ const health = (req, res) => {
 };
 
 /**
- * @desc Endpoint to return SaaS readiness checks (admin only)
+ * @desc Endpoint to return SaaS readiness checks (admin only).
  * @param {Object} req - Express request object
  * @param {Object} res - Express response object
+ * @returns {void}
  */
 const readiness = (req, res) => {
   try {

modules/home/policies/home.policy.js

@@ -13,7 +13,7 @@
 export function homeAbilities(user, membership, { can }) {
   can('read', 'Home');
   if (Array.isArray(user?.roles) && user.roles.includes('admin')) {
-    can('read', 'Readiness');
+    can('manage', 'Readiness');
   }
 }
 

modules/home/services/home.service.js

@@ -119,10 +119,11 @@ const getReadinessStatus = () => {
   const checks = [];
 
   // config — domain
+  const domainSet = isSet(config.domain);
   checks.push({
     category: 'config',
-    status: isSet(config.domain) ? 'ok' : 'warning',
-    message: isSet(config.domain) ? 'Domain configured' : 'Domain not configured',
+    status: domainSet ? 'ok' : 'warning',
+    message: domainSet ? 'Domain configured' : 'Domain not configured',
   });
 
   // security — JWT secret