Commit d49a574
committed
fix(skills): flip PR to ready before waiting on CodeRabbit to avoid a draft deadlock
CodeRabbit never reviews a draft PR. The pull-request skill's monitor loop
could enter (or continue) the CodeRabbit/threads wait while the PR was still
draft, deadlocking silently — observed 2026-07-16: a converging PR sat in
draft with CI green and the CodeRabbit check pending indefinitely, until
manually un-drafted.
- SKILL.md §5: emphasize the ordering invariant — `gh pr ready` MUST run as
soon as draft CI is green, before section 6 starts waiting on any review
signal.
- SKILL.md §6 / monitor-loop.md: add a belt-and-braces draft guard at the top
of every poll pass — if `isDraft: true` and CI is green, flip to ready
immediately. Covers a loop started before the flip, or a rebase/force-push
that reverted the PR back to draft.
Closes #3956
Claude-Session: https://claude.ai/code/session_01WfNC8bt1TgL4AsiYgCEGup1 parent 319a675 commit d49a574
2 files changed
Lines changed: 28 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
106 | | - | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
107 | 109 | | |
108 | 110 | | |
109 | 111 | | |
| |||
126 | 128 | | |
127 | 129 | | |
128 | 130 | | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
129 | 135 | | |
130 | 136 | | |
131 | 137 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| |||
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
37 | 57 | | |
38 | 58 | | |
39 | 59 | | |
| |||
0 commit comments