fix(billing): address 3 CodeRabbit findings on pricing contract + refund service

CR1: pin exact safe defaults in contract test (toEqual instead of typeof)
so regressions that populate RATIOS/STRIPE_PRICE_CENTS/STRIPE_PACK_CENTS
by default are caught.

CR2: guard options param in refundCharge before destructuring — null arg
caused raw TypeError; now throws a clear validation error.

CR3: wiring test imports development.config.js directly (not config/index.js)
so it deterministically targets the new billing.pricing block in the
defaults file, not whichever env the full pipeline resolves.

Author: PierreBrisorgueil

lib/services/tests/billing-pricing-constants.contract.unit.tests.js

@@ -8,21 +8,19 @@ import {
 } from '../../../config/defaults/billing.pricing.constants.js';
 
 describe('billing.pricing.constants — devkit contract:', () => {
-  test('PRICING_VERSION is a non-empty string with YYYY.MM shape (or 0.0.0 default)', () => {
-    expect(typeof PRICING_VERSION).toBe('string');
-    expect(PRICING_VERSION).toMatch(/^\d+\.\d+(\.\d+)?$/);
+  test('PRICING_VERSION is the safe default 0.0.0', () => {
+    expect(PRICING_VERSION).toBe('0.0.0');
   });
-  test('PLAN_QUOTAS is an object with at least `free` key (numeric)', () => {
-    expect(typeof PLAN_QUOTAS).toBe('object');
-    expect(typeof PLAN_QUOTAS.free).toBe('number');
+  test('PLAN_QUOTAS is the safe default { free: 0 }', () => {
+    expect(PLAN_QUOTAS).toEqual({ free: 0 });
   });
-  test('RATIOS is an object (may be empty by default)', () => {
-    expect(typeof RATIOS).toBe('object');
+  test('RATIOS is the safe default empty object', () => {
+    expect(RATIOS).toEqual({});
   });
-  test('STRIPE_PRICE_CENTS is an object (may be empty by default)', () => {
-    expect(typeof STRIPE_PRICE_CENTS).toBe('object');
+  test('STRIPE_PRICE_CENTS is the safe default empty object', () => {
+    expect(STRIPE_PRICE_CENTS).toEqual({});
   });
-  test('STRIPE_PACK_CENTS is an object (may be empty by default)', () => {
-    expect(typeof STRIPE_PACK_CENTS).toBe('object');
+  test('STRIPE_PACK_CENTS is the safe default empty object', () => {
+    expect(STRIPE_PACK_CENTS).toEqual({});
   });
 });

modules/billing/services/billing.refund.service.js

@@ -18,7 +18,11 @@ import getStripe from '../lib/stripe.js';
  * @returns {Promise<Object>} The Stripe refund object.
  */
 // biome-ignore lint/correctness/useQwikValidLexicalScope: false positive — Node.js service, not Qwik
-const refundCharge = async (stripeChargeId, amountCents, { reason } = {}) => {
+const refundCharge = async (stripeChargeId, amountCents, options = {}) => {
+  if (options === null || typeof options !== 'object' || Array.isArray(options)) {
+    throw new Error('invalid argument: options must be a plain object');
+  }
+  const { reason } = options;
   if (typeof stripeChargeId !== 'string' || stripeChargeId.trim() === '') {
     throw new Error('invalid argument: stripeChargeId must be a non-empty string');
   }

modules/billing/tests/billing.pricing.config.wiring.unit.tests.js

@@ -1,17 +1,17 @@
 import { describe, test, expect } from '@jest/globals';
-import config from '../../../config/index.js';
+import defaults from '../../../config/defaults/development.config.js';
 
-describe('config.billing.pricing wiring:', () => {
+describe('config.billing.pricing wiring (development.config.js):', () => {
   test('exposes PRICING_VERSION, PLAN_QUOTAS, RATIOS, STRIPE_PRICE_CENTS, STRIPE_PACK_CENTS', () => {
-    expect(config.billing).toBeDefined();
-    expect(config.billing.pricing).toBeDefined();
-    expect(config.billing.pricing.PRICING_VERSION).toBeDefined();
-    expect(config.billing.pricing.PLAN_QUOTAS).toBeDefined();
-    expect(config.billing.pricing.RATIOS).toBeDefined();
-    expect(config.billing.pricing.STRIPE_PRICE_CENTS).toBeDefined();
-    expect(config.billing.pricing.STRIPE_PACK_CENTS).toBeDefined();
+    expect(defaults.billing).toBeDefined();
+    expect(defaults.billing.pricing).toBeDefined();
+    expect(defaults.billing.pricing.PRICING_VERSION).toBeDefined();
+    expect(defaults.billing.pricing.PLAN_QUOTAS).toBeDefined();
+    expect(defaults.billing.pricing.RATIOS).toBeDefined();
+    expect(defaults.billing.pricing.STRIPE_PRICE_CENTS).toBeDefined();
+    expect(defaults.billing.pricing.STRIPE_PACK_CENTS).toBeDefined();
   });
   test('PLAN_QUOTAS has at least `free` numeric entry by default', () => {
-    expect(typeof config.billing.pricing.PLAN_QUOTAS.free).toBe('number');
+    expect(typeof defaults.billing.pricing.PLAN_QUOTAS.free).toBe('number');
   });
 });