Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 39 additions & 31 deletions modules/home/services/home.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,44 +28,52 @@ const page = async (name) => {
};

/**
* @desc Function to get all versions
* @return {Promise} All versions
* @desc Fetch releases from configured GitHub repos. Returns an empty array on API failure (graceful degradation).
* @return {Promise<Array<{title: string, list: Array}>>} Releases grouped by repo, or [] on error
*/
const releases = async () => {
const requests = config.repos.map((item) =>
axios.get(`https://api.github.com/repos/${item.owner}/${item.repo}/releases`, {
headers: item.token ? { Authorization: `token ${item.token}` } : {},
}),
);
let results = await axios.all(requests);
results = results.map((result, i) => ({
title: config.repos[i].title,
list: result.data.map((release) => ({
name: release.name,
prerelease: release.prerelease,
published_at: release.published_at,
})),
}));
return Promise.resolve(results);
try {
const requests = config.repos.map((item) =>
axios.get(`https://api.github.com/repos/${item.owner}/${item.repo}/releases`, {
headers: item.token ? { Authorization: `token ${item.token}` } : {},
}),
);
let results = await axios.all(requests);
results = results.map((result, i) => ({
title: config.repos[i].title,
list: result.data.map((release) => ({
name: release.name,
prerelease: release.prerelease,
published_at: release.published_at,
})),
}));
return results;
} catch (_err) {
return [];
}
Comment thread
PierreBrisorgueil marked this conversation as resolved.
};

/**
* @desc Function to get all changelogs
* @return {Promise} All changelogs
* @desc Fetch changelogs from configured GitHub repos. Returns an empty array on API failure (graceful degradation).
* @return {Promise<Array<{title: string, markdown: string}>>} Changelogs grouped by repo, or [] on error
*/
const changelogs = async () => {
const repos = _.filter(config.repos, (repo) => repo.changelog);
const requests = repos.map((item) =>
axios.get(`https://api.github.com/repos/${item.owner}/${item.repo}/contents/${item.changelog}`, {
headers: item.token ? { Authorization: `token ${item.token}` } : {},
}),
);
let results = await axios.all(requests);
results = results.map((result, i) => ({
title: config.repos[i].title,
markdown: Base64.decode(result.data.content),
}));
return Promise.resolve(results);
try {
const repos = _.filter(config.repos, (repo) => repo.changelog);
const requests = repos.map((item) =>
axios.get(`https://api.github.com/repos/${item.owner}/${item.repo}/contents/${item.changelog}`, {
headers: item.token ? { Authorization: `token ${item.token}` } : {},
}),
);
let results = await axios.all(requests);
results = results.map((result, i) => ({
title: repos[i].title,
markdown: Base64.decode(result.data.content),
}));
return results;
} catch (_err) {
return [];
}
};

/**
Expand Down
20 changes: 10 additions & 10 deletions modules/home/tests/home.integration.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,20 +91,20 @@ describe('Home integration tests:', () => {
}
});

test('should return 422 when GitHub API fails for releases', async () => {
test('should return empty releases gracefully when GitHub API fails', async () => {
axios.get.mockRejectedValueOnce(new Error('GitHub API unavailable'));
const result = await agent.get('/api/home/releases').expect(422);
expect(result.body.type).toBe('error');
expect(result.body.message).toBe('Unprocessable Entity');
expect(result.body.description).toBe('GitHub API unavailable.');
const result = await agent.get('/api/home/releases').expect(200);
expect(result.body.type).toBe('success');
expect(result.body.message).toBe('releases');
expect(result.body.data).toEqual([]);
});

test('should return 422 when GitHub API fails for changelogs', async () => {
test('should return empty changelogs gracefully when GitHub API fails', async () => {
axios.get.mockRejectedValueOnce(new Error('GitHub API unavailable'));
const result = await agent.get('/api/home/changelogs').expect(422);
expect(result.body.type).toBe('error');
expect(result.body.message).toBe('Unprocessable Entity');
expect(result.body.description).toBe('GitHub API unavailable.');
const result = await agent.get('/api/home/changelogs').expect(200);
expect(result.body.type).toBe('success');
expect(result.body.message).toBe('changelogs');
expect(result.body.data).toEqual([]);
});

test('should use Authorization header when a token is configured for releases', async () => {
Expand Down
Loading