Skip to content

feat(verify): add coverage enforcement to verify skill#3304

Merged
PierreBrisorgueil merged 2 commits into
masterfrom
feat/verify-coverage
Mar 25, 2026
Merged

feat(verify): add coverage enforcement to verify skill#3304
PierreBrisorgueil merged 2 commits into
masterfrom
feat/verify-coverage

Conversation

@PierreBrisorgueil

Copy link
Copy Markdown
Contributor

Summary

  • /verify skill now runs tests with coverage enforcement (npm run test:coverage) instead of plain npm run test:all
  • If coverage drops below the thresholds defined in jest.config.js (statements 80%, branches 65%, functions 80%, lines 80%), the verify step fails
  • Maintains the infra-up/infra-down detection: unit-only coverage when MongoDB is unreachable

Test plan

  • Run /verify with infra up — confirms npm run test:coverage executes and enforces thresholds
  • Run /verify with infra down — confirms unit-only coverage runs with warning
  • Intentionally drop coverage below threshold — confirms verify fails

Copilot AI review requested due to automatic review settings March 25, 2026 10:47
@coderabbitai

coderabbitai Bot commented Mar 25, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@PierreBrisorgueil has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 44 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9d810f61-db54-4db1-be2a-2293bb00e455

📥 Commits

Reviewing files that changed from the base of the PR and between 1a10722 and 4c2fbc3.

📒 Files selected for processing (1)
  • .claude/skills/verify/SKILL.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/verify-coverage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the /verify skill documentation to run Jest with coverage enforcement so verification fails when coverage drops below the thresholds configured in jest.config.js.

Changes:

  • Switches infra-up test command from npm run test:all to npm run test:coverage.
  • Updates infra-down guidance to run unit-only tests with coverage and adds a note about threshold enforcement.

Comment thread .claude/skills/verify/SKILL.md Outdated
@PierreBrisorgueil
PierreBrisorgueil merged commit a3d4216 into master Mar 25, 2026
3 checks passed
@PierreBrisorgueil
PierreBrisorgueil deleted the feat/verify-coverage branch March 25, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants