Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions config/defaults/billing.pricing.constants.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
/**
* Billing pricing constants — devkit-shipped export contract with safe defaults.
*
* Downstreams override the VALUES (not the contract) by setting `billing.pricing.*`
* in their `config/defaults/<project>.config.js`. The global `config` exposes the
* merged result at `config.billing.pricing`. Importers should always read through
* `config.billing.pricing.PLAN_QUOTAS` etc., NOT from this file directly — that
* way downstream values win the glob-merge.
*
* Why ship from devkit:
* - Every downstream running billing wants the same export shape.
* - Migrations + contract tests + costs service all benefit from a single import path.
* - Trawl had this file at `modules/billing/config/billing.pricing.constants.js` with
* 6+ importers — promoted upstream in plan `2026-06-02-trawl-billing-residual-cleanup.md`.
*
* @module billing.pricing.constants
*/
Comment thread
PierreBrisorgueil marked this conversation as resolved.

/** @type {string} YYYY.MM pricing version (e.g. '2026.05'). Default 0.0.0 = unset. */
export const PRICING_VERSION = '0.0.0';

/** @type {Record<string, number>} Weekly meter quota in compute units per plan. */
export const PLAN_QUOTAS = { free: 0 };

/** @type {Record<string, number>} Compute unit multipliers per feature key. */
export const RATIOS = {};

/** @type {Record<string, { monthly: number, annual: number }>} Stripe price cents per plan. */
export const STRIPE_PRICE_CENTS = {};

/** @type {Record<string, number>} Stripe price cents per extras pack. */
export const STRIPE_PACK_CENTS = {};
18 changes: 18 additions & 0 deletions config/defaults/development.config.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
import {
PRICING_VERSION,
PLAN_QUOTAS,
RATIOS,
STRIPE_PRICE_CENTS,
STRIPE_PACK_CENTS,
} from './billing.pricing.constants.js';

const config = {
app: {
title: 'Devkit Node - Development Environment',
Expand Down Expand Up @@ -142,6 +150,16 @@ const config = {
},
},
},
billing: {
/**
* Pricing constants contract — safe devkit defaults.
* Downstream projects override these values in their own config file.
* These values are also directly importable from
* `config/defaults/billing.pricing.constants.js` for migrations and
* standalone tooling that cannot import the full config object.
*/
pricing: { PRICING_VERSION, PLAN_QUOTAS, RATIOS, STRIPE_PRICE_CENTS, STRIPE_PACK_CENTS },
},
Comment thread
PierreBrisorgueil marked this conversation as resolved.
};

export default config;
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { describe, test, expect } from '@jest/globals';
import {
PRICING_VERSION,
PLAN_QUOTAS,
RATIOS,
STRIPE_PRICE_CENTS,
STRIPE_PACK_CENTS,
} from '../../../config/defaults/billing.pricing.constants.js';

describe('billing.pricing.constants — devkit contract:', () => {
test('PRICING_VERSION is a non-empty string with YYYY.MM shape (or 0.0.0 default)', () => {
expect(typeof PRICING_VERSION).toBe('string');
expect(PRICING_VERSION).toMatch(/^\d+\.\d+(\.\d+)?$/);
});
test('PLAN_QUOTAS is an object with at least `free` key (numeric)', () => {
expect(typeof PLAN_QUOTAS).toBe('object');
expect(typeof PLAN_QUOTAS.free).toBe('number');
});
test('RATIOS is an object (may be empty by default)', () => {
expect(typeof RATIOS).toBe('object');
});
test('STRIPE_PRICE_CENTS is an object (may be empty by default)', () => {
expect(typeof STRIPE_PRICE_CENTS).toBe('object');
});
test('STRIPE_PACK_CENTS is an object (may be empty by default)', () => {
expect(typeof STRIPE_PACK_CENTS).toBe('object');
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
});
49 changes: 49 additions & 0 deletions modules/billing/services/billing.refund.service.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
/**
* Module dependencies
*/
import getStripe from '../lib/stripe.js';

/**
* @function refundCharge
* @description Initiate a Stripe refund for a given charge.
* Wraps stripe.refunds.create with a deterministic idempotency key so
* retries on network failures never create duplicate refunds.
* The actual ledger debit happens via the `charge.refunded` webhook
* (single source of truth) — this service ONLY initiates the Stripe refund.
*
* @param {string} stripeChargeId - Stripe charge ID (ch_xxx). Must be non-empty.
* @param {number|undefined} [amountCents] - Amount to refund in cents. Omit for full refund. Must be > 0 if provided.
* @param {Object} [options={}] - Optional Stripe refund options.
* @param {string} [options.reason] - Optional Stripe refund reason.
* @returns {Promise<Object>} The Stripe refund object.
Comment thread
PierreBrisorgueil marked this conversation as resolved.
*/
// biome-ignore lint/correctness/useQwikValidLexicalScope: false positive — Node.js service, not Qwik
const refundCharge = async (stripeChargeId, amountCents, { reason } = {}) => {
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
if (typeof stripeChargeId !== 'string' || stripeChargeId.trim() === '') {
throw new Error('invalid argument: stripeChargeId must be a non-empty string');
}
if (amountCents !== undefined) {
if (!Number.isInteger(amountCents) || amountCents <= 0) {
throw new Error('invalid argument: amountCents must be a positive integer');
}
}

const stripe = getStripe();
if (!stripe) throw new Error('Stripe is not configured');

const idempotencyKey = `refund_${stripeChargeId}_${amountCents ?? 'full'}`;

const params = {
charge: stripeChargeId,
reason: reason || 'requested_by_customer',
};
if (amountCents !== undefined) {
params.amount = amountCents;
}

return stripe.refunds.create(params, { idempotencyKey });
};
Comment thread
PierreBrisorgueil marked this conversation as resolved.
Outdated

export default {
refundCharge,
};
17 changes: 17 additions & 0 deletions modules/billing/tests/billing.pricing.config.wiring.unit.tests.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { describe, test, expect } from '@jest/globals';
import config from '../../../config/index.js';

describe('config.billing.pricing wiring:', () => {
test('exposes PRICING_VERSION, PLAN_QUOTAS, RATIOS, STRIPE_PRICE_CENTS, STRIPE_PACK_CENTS', () => {
expect(config.billing).toBeDefined();
expect(config.billing.pricing).toBeDefined();
expect(config.billing.pricing.PRICING_VERSION).toBeDefined();
expect(config.billing.pricing.PLAN_QUOTAS).toBeDefined();
expect(config.billing.pricing.RATIOS).toBeDefined();
expect(config.billing.pricing.STRIPE_PRICE_CENTS).toBeDefined();
expect(config.billing.pricing.STRIPE_PACK_CENTS).toBeDefined();
});
test('PLAN_QUOTAS has at least `free` numeric entry by default', () => {
expect(typeof config.billing.pricing.PLAN_QUOTAS.free).toBe('number');
});
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
import { jest, describe, test, expect, beforeEach } from '@jest/globals';

describe('billing.refund.service — refundCharge:', () => {
let RefundService;
let mockStripe;
let mockRefundsCreate;

beforeEach(async () => {
jest.resetModules();
mockRefundsCreate = jest.fn().mockResolvedValue({ id: 're_test_123', status: 'succeeded' });
mockStripe = { refunds: { create: mockRefundsCreate } };
jest.unstable_mockModule('../lib/stripe.js', () => ({
default: jest.fn().mockReturnValue(mockStripe),
}));
({ default: RefundService } = await import('../services/billing.refund.service.js'));
});

test('initiates a full refund when amountCents omitted', async () => {
const result = await RefundService.refundCharge('ch_test_123');
expect(mockRefundsCreate).toHaveBeenCalledTimes(1);
const callArgs = mockRefundsCreate.mock.calls[0][0];
expect(callArgs.charge).toBe('ch_test_123');
expect(callArgs.amount).toBeUndefined();
expect(result.id).toBe('re_test_123');
});

test('uses partial amount when amountCents provided', async () => {
await RefundService.refundCharge('ch_test_456', 5000);
expect(mockRefundsCreate).toHaveBeenCalledWith(expect.objectContaining({
charge: 'ch_test_456',
amount: 5000,
}), expect.any(Object));
});

test('passes deterministic idempotency key derived from charge+amount', async () => {
await RefundService.refundCharge('ch_idem_test', 1000);
const idemArg = mockRefundsCreate.mock.calls[0][1];
expect(idemArg).toBeDefined();
expect(idemArg.idempotencyKey).toBeDefined();
// Same charge+amount → same key (deterministic)
await RefundService.refundCharge('ch_idem_test', 1000);
const idemArg2 = mockRefundsCreate.mock.calls[1][1];
expect(idemArg2.idempotencyKey).toBe(idemArg.idempotencyKey);
});

test('passes reason when provided', async () => {
await RefundService.refundCharge('ch_test', undefined, { reason: 'requested_by_customer' });
expect(mockRefundsCreate).toHaveBeenCalledWith(expect.objectContaining({
reason: 'requested_by_customer',
}), expect.any(Object));
});

test('throws when stripeChargeId is empty', async () => {
await expect(RefundService.refundCharge('')).rejects.toThrow();
});

test('throws when amountCents is 0 or negative', async () => {
await expect(RefundService.refundCharge('ch_x', 0)).rejects.toThrow();
await expect(RefundService.refundCharge('ch_x', -100)).rejects.toThrow();
});
});
Loading