fix(billing): preserve signup redirect query + drop dead view code

Phase 0 critical-review BLOCK findings — iter 2:

- [high] Free+guest CTA `cta.to` was '/signup' (string), losing the redirect=/pricing
  query param. Card skips emit when cta.to is set (intentional double-nav fix), so
  the view's onCtaClick fallback that pushed /signup?redirect=/pricing was dead.
  Fix: pass cta.to as { path: '/signup', query: { redirect: '/pricing' } } — v-btn :to
  accepts the same shape as $router.push().
- [medium] Drop dead `meterMode` computed from the view (only consumed by the
  removed _equivalences logic).
- [low] Update billing.pricing.view.unit.tests.js mock fixtures to V4 schema
  (title/subtitle/highlight) — masked schema-compliance gaps.
- [low] Clarify BillingCardComponent ITEM SCHEMA doc: cta is a string in
  static-content plans but expanded into an object by resolvedPlanItems; cta-click
  emit guard now documented (disabled OR to=set).

Note: usePricing.maxAnnualSavingsPct stays — it's a public composable API still
tested by billing.usePricing.unit.tests.js. Downstream may consume it.

All tests green (1669/1669). Lint clean.

Author: PierreBrisorgueil

src/modules/billing/components/billing.card.component.vue

@@ -10,28 +10,33 @@
   USAGE (pack — from billing.packs.component.vue):
   <BillingCardComponent :item="resolvedPackItem" @cta-click="onCtaClick" />
 
-  ITEM SCHEMA:
+  ITEM SCHEMA (fully resolved — parent transforms static-content plan/pack into this):
     id        : string
     title     : string                   — large card heading
     subtitle  : string                   — 1-liner below title
-    price     : { amount: string, period: string|null }
+    price     : { amount: string, period: string|null, chip?: { text: string, color?: string } }
                   e.g. { amount: 'FREE', period: null }
-                  e.g. { amount: '$39', period: '/month' }
+                  e.g. { amount: '$39', period: '/month', chip: { text: 'Save 17%', color: 'success' } }
     cta       : {
-                  label    : string,
+                  label    : string,                          — resolved label (parent picks "Sign up" / "Current Plan" / etc.)
                   variant  : 'elevated'|'outlined'|'flat'|'tonal',
                   color    : string|null,
                   disabled : boolean,
                   loading  : boolean,
-                  to       : string|null,   — router-link target (free plan signup)
+                  to       : string|RouteLocationRaw|null,    — router-link target (v-btn :to passes through). Object form preserves query params.
                 }
+                Note: static-content plans carry `cta` as a plain string (the label).
+                The parent (e.g. billing.pricing.view.vue resolvedPlanItems) expands it
+                into this object — the name collision between the two layers is intentional
+                but worth flagging for downstream overrides.
     info      : string|null              — ops-eval line, shown between CTA and features
     features  : [{ icon: string, color: string, text: string }]
     badge     : string|null              — e.g. 'MOST POPULAR'
     highlight : boolean                  — elevated card variant
 
   EVENTS:
-  - cta-click ({ id }): emitted on CTA click (parent handles routing/checkout)
+  - cta-click ({ id }): emitted on CTA click. Skipped when cta.disabled OR cta.to is set
+                        (router-link owns navigation in the latter case — see onCtaClick).
 -->
 <template>
   <v-card

src/modules/billing/tests/billing.pricing.view.unit.tests.js

@@ -30,7 +30,11 @@ vi.mock('../../auth/stores/auth.store', () => ({
 
 const pricingState = vi.hoisted(() => ({
   mode: 'subscription',
-  plans: [{ id: 'free', name: 'Free' }, { id: 'pro', name: 'Pro' }],
+  // V4 schema — title/subtitle/highlight (matches static-content & BillingCardComponent contract).
+  plans: [
+    { id: 'free', title: 'Free', subtitle: 'For starters', highlight: false, badge: null, cta: 'Get started', features: [] },
+    { id: 'pro', title: 'Pro', subtitle: 'For pros', highlight: false, badge: null, cta: 'Upgrade', features: [] },
+  ],
   packs: [],
   faqs: { title: '', subtitle: null, content: [] },
   tabs: {},
@@ -284,7 +288,11 @@ describe('BillingPricingView — mode-aware layout', () => {
       pricingState.plans = plans;
       pricingState.hasPlans = plans.length > 0;
     } else {
-      pricingState.plans = [{ id: 'free', name: 'Free' }, { id: 'pro', name: 'Pro' }];
+      // V4 schema — title/subtitle/highlight (matches static-content & BillingCardComponent contract).
+      pricingState.plans = [
+        { id: 'free', title: 'Free', subtitle: 'For starters', highlight: false, badge: null, cta: 'Get started', features: [] },
+        { id: 'pro', title: 'Pro', subtitle: 'For pros', highlight: false, badge: null, cta: 'Upgrade', features: [] },
+      ];
       pricingState.hasPlans = true;
     }
     pricingState.packs = pricingMode === 'packs' ? [{ id: 'p1', name: 'Pack 500' }] : [];

src/modules/billing/views/billing.pricing.view.vue

@@ -207,9 +207,6 @@ export default {
       if (!this.authStore.isLoggedIn) return null;
       return this.billingStore.subscription?.plan ?? 'free';
     },
-    meterMode() {
-      return this.authStore.serverConfig?.billing?.meterMode === true;
-    },
     hasPaidPlans() {
       return this.plans.some((p) => p.id !== 'free');
     },
@@ -296,7 +293,11 @@ export default {
           ctaVariant = 'outlined';
           ctaColor = null;
           ctaDisabled = false;
-          ctaTo = '/signup';
+          // Preserve the `redirect` query param so the user lands back on the pricing
+          // page after signup. v-btn's :to accepts the same shape as $router.push().
+          // The card skips its cta-click emit when cta.to is set (router-link owns
+          // the navigation), so the view's onCtaClick fallback is intentionally bypassed.
+          ctaTo = { path: '/signup', query: { redirect: '/pricing' } };
         } else {
           ctaLabel = plan.cta;
           ctaVariant = plan.highlight ? 'flat' : 'outlined';