Skip to content

Commit f09975c

Browse files
chore(core): remove orphan PageTabs + clean post-i18n doc drift
- delete core.pageTabs.component.{vue,test} (zero consumers since SurfaceTabBar) - MIGRATIONS.md: remove dangling src/lib/plugins/i18n.js reference; add PageTabs drop note - billing.static-content.js: fix 3 stale "fallback to i18n keys" comments Closes audit P1 (2026-05-21).
1 parent 6477873 commit f09975c

4 files changed

Lines changed: 15 additions & 144 deletions

File tree

MIGRATIONS.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,14 @@ This migration is **opt-in per module** — coordinate with the maintainer of ea
266266

267267
---
268268

269+
## Drop CorePageTabsComponent (2026-05-21)
270+
271+
The `core.pageTabs.component.vue` introduced in PR #4183 was abandoned 2h after merge in favor of `SurfaceTabBar` (PR #4187). The component had zero consumers and is removed.
272+
273+
**Downstream action:** if you propagated `core.pageTabs.component.{vue,test}` via `/update-stack`, delete both files. Use `SurfaceTabBar` for any tab layouts.
274+
275+
---
276+
269277
## Legal module + cookie consent banner (2026-05-07)
270278

271279
**Non-breaking for default consumers.** New `modules/legal/` ships:
@@ -285,7 +293,7 @@ Disabled by default. Enable in `modules/legal/config/legal.{env}.config.js` (or
285293
- MODIFIED: `src/modules/core/components/core.footer.component.vue` — auto-injects a "Legal" section when `legal.cookieConsent.enabled` or any `legal.pages.items[*].enabled` is true. Also fixes a pre-existing bug where the footer was hidden on hard-load (the `$route` watcher didn't fire on initial mount); a `created()` hook now initializes `enabled` from `$route.meta.footer`.
286294
- MODIFIED: `src/modules/app/app.vue` — global mount of `<legalCookieBanner />`.
287295
- MODIFIED: `src/modules/app/app.router.js` — concatenates legal routes (returns empty when `pages.enabled: false`).
288-
- MODIFIED: `src/lib/plugins/i18n.js` — imports `legalEn` / `legalFr`.
296+
- ~~MODIFIED: `src/lib/plugins/i18n.js` — imports `legalEn` / `legalFr`.~~ **Superseded:** `src/lib/plugins/i18n.js` was removed entirely in PR #4169 (i18n removal). Legal strings are now hardcoded in English directly in the legal components.
289297

290298
### Action for downstream projects
291299

src/modules/billing/config/billing.static-content.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,8 @@ export const packs = [
163163
];
164164

165165
/**
166-
* @desc FAQ section content. Title + subtitle are optional (fallback to i18n).
166+
* @desc FAQ section content. Title + subtitle are optional (fallback to hardcoded English defaults:
167+
* `'Frequently asked questions'` / `null` — no subtitle by default).
167168
* @type {{ title?: string, subtitle?: string, content: Array<{id: string, question: string, answer: string}> }}
168169
*/
169170
export const faqs = {
@@ -190,8 +191,8 @@ export const faqs = {
190191

191192
/**
192193
* @desc Configurable tab labels (used in 'both-tabs' mode).
193-
* Each field is optional — when omitted the view falls back to i18n keys
194-
* `billing.pricing.tabs.plans` / `billing.pricing.tabs.units`.
194+
* Each field is optional — when omitted the view falls back to hardcoded English defaults
195+
* (`'Plans'` / `'Units'`).
195196
* Downstream projects can override either or both labels per project.
196197
* @type {{ plans?: string, units?: string }}
197198
*/
@@ -201,8 +202,8 @@ export const tabs = {
201202
};
202203

203204
/**
204-
* @desc Page header copy. When `null`/absent, falls back to i18n keys
205-
* `billing.pricing.title` / `billing.pricing.subtitle`.
205+
* @desc Page header copy. When `null`/absent, falls back to hardcoded English defaults
206+
* (`'Pricing'` / `'Choose the plan that fits your needs.'`).
206207
* @type {{ title?: string|null, subtitle?: string|null }}
207208
*/
208209
export const header = {

src/modules/core/components/core.pageTabs.component.vue

Lines changed: 0 additions & 79 deletions
This file was deleted.

src/modules/core/tests/core.pageTabs.component.unit.tests.js

Lines changed: 0 additions & 59 deletions
This file was deleted.

0 commit comments

Comments
 (0)