Problem
organizations.domainJoin.e2e.tests.js still tests the old pendingJoin flow:
- "member signs up via UI — sees pending message, no sidenav" expects
text=request to join which was the organization-required pending banner
- "member signs in — lands on organization-required" expects URL
/organization-required
- "owner approves member join request" polls
/organizations/{id}/requests expecting > 0 items
These all fail after pierreb-devkit/Node#3680 (D5 always-create workspace) was merged, since:
- Domain-match signup now creates a workspace for the user (no pending limbo)
- User lands on main app with
currentOrganization set
pendingJoin is gone — suggestedJoin hint returned instead
/organizations/{id}/requests returns 0 items at signup
Affected file
src/modules/organizations/tests/organizations.domainJoin.e2e.tests.js
Steps to reproduce
Run npx playwright test organizations.domainJoin.e2e.tests.js against pierreb-devkit/Node@master (post-#3680). Test "member signs up via UI — sees pending message, no sidenav" fails with element(s) not found.
Fix
Update 3 tests to assert landing on main app (not org-required), drop approval test, keep access control tests unchanged.
Downstream workaround shipped in comes-io/trawl_vue#908.
Problem
organizations.domainJoin.e2e.tests.jsstill tests the oldpendingJoinflow:text=request to joinwhich was theorganization-requiredpending banner/organization-required/organizations/{id}/requestsexpecting > 0 itemsThese all fail after
pierreb-devkit/Node#3680(D5 always-create workspace) was merged, since:currentOrganizationsetpendingJoinis gone —suggestedJoinhint returned instead/organizations/{id}/requestsreturns 0 items at signupAffected file
src/modules/organizations/tests/organizations.domainJoin.e2e.tests.jsSteps to reproduce
Run
npx playwright test organizations.domainJoin.e2e.tests.jsagainstpierreb-devkit/Node@master(post-#3680). Test "member signs up via UI — sees pending message, no sidenav" fails withelement(s) not found.Fix
Update 3 tests to assert landing on main app (not org-required), drop approval test, keep access control tests unchanged.
Downstream workaround shipped in
comes-io/trawl_vue#908.