feat(organizations): soft suggestedJoin onboarding banner + recovery-screen copy

[PierreBrisorgueil]

What

PR (d) — the final PR of the Devkit onboarding/billing/UI-decoupling effort (PR(b) #4170, PR(c) #4175, PR(a) #3680 all merged). Consumes the suggestedJoin signup-response field PR(a) added.

• Auth store suggestedJoin lifecycle — captured from the signup response (graceful no-op if absent → backward/forward compatible); setSuggestedJoin/dismissSuggestedJoin/clearSuggestedJoinIfMember; cleared on signout; self-healing localStorage persistence (try/catch + payload guard) mirroring the existing CookieExpire/UserRoles pattern.
• organizations.suggestedJoinBanner — app-level dismissible banner (mounted in app.vue after adminPendingBanner, mirrors that sibling). Renders only when suggestedJoin truthy (safe global no-op when null). CTA reuses organizationsStore.createJoinRequest. Benign-rejection handling (verified against the merged Node strings): Already a member of this organization / A pending request already exists / cross-org one-pending cap You already have a pending request… / 404 → neutral info toast + dismiss, never red. Genuine 500/network → error toast, NOT dismissed (retry). Double-submit guarded (Vuetify 4 :loading doesn't block clicks).
• Recovery-screen copy — organizations.required.view.vue recentred from onboarding to recovery framing ("No workspace found. Create one or ask for an invitation."). Copy-only; all flows (request-join / create-org / check-status / sign-out) byte-identical.

Verification

• npm run lint: 0 errors. Full suite: 110 files / 1843 tests, 0 failures.
• Per-task two-stage review (spec + code-quality) with fix loops — caught a corrupt-storage init fragility, an unguarded server payload, a double-submit bug, and a spec gap where the cross-org one-pending cap was wrongly classified as a hard error (now benign per spec, verified against the real merged backend strings).

Risk

Low — additive auth-store state + an opt-in banner that no-ops when suggestedJoin is absent (older/other backends unaffected). Recovery copy is behavior-neutral. Downstream propagates via /update-stack.

6 commits (f7ba701b→a7ccc3c2).

[coderabbitai]

Warning

Rate limit exceeded

@PierreBrisorgueil has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 4 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 708c5d44-e2c4-48e4-8dc7-2cadea203175

📥 Commits

Reviewing files that changed from the base of the PR and between 1f36137 and e32fe7e.

📒 Files selected for processing (7)

• src/modules/app/app.vue
• src/modules/auth/stores/auth.store.js
• src/modules/auth/tests/auth.store.unit.tests.js
• src/modules/organizations/components/organizations.suggestedJoinBanner.component.vue
• src/modules/organizations/tests/organizations.required.view.unit.tests.js
• src/modules/organizations/tests/organizations.suggestedJoinBanner.component.unit.tests.js
• src/modules/organizations/views/organizations.required.view.vue

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/suggested-join-banner

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.55%. Comparing base (1f36137) to head (e32fe7e).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4176   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          31       31           
  Lines        1114     1136   +22     
  Branches      321      328    +7     
=======================================
+ Hits         1109     1131   +22     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

Adds a new “suggested workspace join” onboarding affordance by persisting suggestedJoin from the signup response in the auth store and surfacing it as a dismissible app-level banner, plus updates the “organization required” screen copy to a recovery framing.

Changes:

• Persist suggestedJoin in auth.store (init from localStorage, set/dismiss/clear helpers, clear on signout) and capture it from the signup response.
• Introduce organizationsSuggestedJoinBanner and comprehensive unit tests covering success, benign rejection, and error flows.
• Update organizations.required.view copy and extend unit tests for the new recovery wording.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/modules/organizations/views/organizations.required.view.vue	Updates heading/intro text to recovery framing (“No workspace found”).
src/modules/organizations/tests/organizations.required.view.unit.tests.js	Adds assertions for the updated recovery copy and confirms key UI actions remain present.
src/modules/organizations/components/organizations.suggestedJoinBanner.component.vue	New dismissible banner + CTA to request access, with benign-error handling and feedback snackbar.
src/modules/organizations/tests/organizations.suggestedJoinBanner.component.unit.tests.js	New unit tests for banner rendering, request flow, benign errors, and double-submit guard.
src/modules/auth/stores/auth.store.js	Adds suggestedJoin state, persistence/init, and lifecycle actions; sets from signup response and clears on signout.
src/modules/auth/tests/auth.store.unit.tests.js	Adds unit tests for suggestedJoin state lifecycle, persistence, and storage corruption handling.
src/modules/app/app.vue	Mounts the new organizations suggested-join banner at the app level.

Comments suppressed due to low confidence (2)

src/modules/auth/stores/auth.store.js:172

• setSuggestedJoin() only checks for a generic object, so arrays or objects missing orgId/orgName will be persisted to localStorage and later treated as a valid suggested join. Validate that payload.orgId and payload.orgName are non-empty strings (and ignore + avoid persisting otherwise) to keep the store contract consistent.

    setSuggestedJoin(payload) {
      if (!payload || typeof payload !== 'object') return;
      this.suggestedJoin = payload;
      localStorage.setItem(`${config.cookie.prefix}SuggestedJoin`, JSON.stringify(payload));
    },

src/modules/organizations/components/organizations.suggestedJoinBanner.component.vue:8

• The banner uses v-model="visible" but visible is a plain data field with no setter side-effect. If the snackbar closes via internal behavior (e.g., ESC / programmatic model update), visible becomes false while suggestedJoin stays persisted, leaving the banner permanently hidden until storage is cleared. Mirror organizations.adminPendingBanner's pattern: implement visible as a computed with a setter that calls dismiss() when set to false (or watch visible and dismiss).

    <v-snackbar
      v-model="visible"
      location="top right"
      color="info"
      :timeout="-1"
      multi-line