chore(core): remove orphan PageTabs + clean post-i18n doc drift#4192
Conversation
- delete core.pageTabs.component.{vue,test} (zero consumers since SurfaceTabBar)
- MIGRATIONS.md: remove dangling src/lib/plugins/i18n.js reference; add PageTabs drop note
- billing.static-content.js: fix 3 stale "fallback to i18n keys" comments
Closes audit P1 (2026-05-21).
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes an unused core tab component introduced in an earlier refactor, and cleans up documentation/comment drift caused by the vue-i18n removal and the subsequent tab-bar consolidation.
Changes:
- Deleted orphan
core.pageTabscomponent and its unit test. - Updated
MIGRATIONS.mdto note the removal and to strike/supersede a stalesrc/lib/plugins/i18n.jsreference. - Updated JSDoc/comments in
billing.static-content.jsto replace stale “fallback to i18n” wording with English-default behavior notes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/modules/core/tests/core.pageTabs.component.unit.tests.js | Removes the unit test for the now-deleted orphan core.pageTabs component. |
| src/modules/core/components/core.pageTabs.component.vue | Deletes the unused CorePageTabs implementation (superseded by CoreSurfaceTabBar). |
| src/modules/billing/config/billing.static-content.js | Updates doc comments describing runtime fallback behavior after i18n removal. |
| MIGRATIONS.md | Adds a migration note for dropping core.pageTabs and marks an i18n-plugin reference as superseded. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4192 +/- ##
=======================================
Coverage 99.56% 99.56%
=======================================
Files 31 31
Lines 1140 1140
Branches 329 329
=======================================
Hits 1135 1135
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
…ccuracy (CR) - MIGRATIONS.md: replace SurfaceTabBar → CoreSurfaceTabBar, make downstream deletion paths explicit (vue + test file separately) - static-content.js faqs @type: add string|null to subtitle, describe falsy fallback - static-content.js tabs: clarify two-layer fallback (devkit default 'Extras' vs view hardcoded 'Units' when field absent/falsy) - static-content.js header: wording updated to 'any falsy value (including empty string) triggers view fallback'
Summary
core.pageTabs.component.{vue,test}— orphan component from PR feat(core): reusable PageTabs component + Account view refactor #4183 abandoned 2h after merge forSurfaceTabBar(PR refactor(ui): homogenize Account, Organization detail, and Admin pages #4187), zero consumers in devkit + downstreamMIGRATIONS.md— strikethrough + Superseded note on danglingsrc/lib/plugins/i18n.jsreference (file removed in PR chore(i18n): remove vue-i18n entirely — inline English strings #4169), adds drop note grouped with other 2026-05-21 entriesbilling.static-content.jswith the exact runtime EN defaults (verified against the view template)Context — audit P1 (2026-05-21)
Devkit audit flagged 3 doc-drift issues left over from i18n removal + abandoned PageTabs work. This PR cleans them all in one chore.
Reviews completed before push :
f09975cbuser.view.unit.tests.js:150-159is dead post-deletion ; 1 nit : MIGRATIONS doesn't call out sentinel test for downstream — deferred to follow-up)Doc-sync ack
[doc-sync ack]MIGRATIONS.md sentinel test inuser.view.unit.tests.jsleft intact — both reviewers flagged as dead weight, deferring to follow-up issue to keep this PR scope tightTest plan
NODE_ENV=devkit npm run lint— cleanNODE_ENV=devkit npm run test:unit— 1910/1910 tests passPlan
docs/superpowers/plans/2026-05-21-devkit-audit-p0-p1-fixes.mdPhase 3.