Skip to content

chore(core): remove orphan PageTabs + clean post-i18n doc drift#4192

Merged
PierreBrisorgueil merged 2 commits into
masterfrom
chore/cleanup-dead-pagetabs-doc-drift
May 22, 2026
Merged

chore(core): remove orphan PageTabs + clean post-i18n doc drift#4192
PierreBrisorgueil merged 2 commits into
masterfrom
chore/cleanup-dead-pagetabs-doc-drift

Conversation

@PierreBrisorgueil
Copy link
Copy Markdown
Collaborator

Summary

Context — audit P1 (2026-05-21)

Devkit audit flagged 3 doc-drift issues left over from i18n removal + abandoned PageTabs work. This PR cleans them all in one chore.

Reviews completed before push :

  • In-session spec review : ✅ compliant (4 files exactly as scoped)
  • In-session code-quality review : 2 IMPORTANT (MIGRATIONS placement + heading format) + 3 MINOR → fixes in commit f09975cb
  • DeepSeek pre-push gate : OK with nits (1 low : sentinel test in user.view.unit.tests.js:150-159 is dead post-deletion ; 1 nit : MIGRATIONS doesn't call out sentinel test for downstream — deferred to follow-up)

Doc-sync ack

  • [doc-sync ack] MIGRATIONS.md sentinel test in user.view.unit.tests.js left intact — both reviewers flagged as dead weight, deferring to follow-up issue to keep this PR scope tight

Test plan

  • NODE_ENV=devkit npm run lint — clean
  • NODE_ENV=devkit npm run test:unit — 1910/1910 tests pass
  • grep confirmed zero PageTabs consumers in devkit + 5 downstream repos
  • CI green
  • CodeRabbit clean

Plan

docs/superpowers/plans/2026-05-21-devkit-audit-p0-p1-fixes.md Phase 3.

- delete core.pageTabs.component.{vue,test} (zero consumers since SurfaceTabBar)
- MIGRATIONS.md: remove dangling src/lib/plugins/i18n.js reference; add PageTabs drop note
- billing.static-content.js: fix 3 stale "fallback to i18n keys" comments

Closes audit P1 (2026-05-21).
Copilot AI review requested due to automatic review settings May 21, 2026 20:10
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Warning

Rate limit exceeded

@PierreBrisorgueil has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 22 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 90270981-548b-4132-ade8-46a9e119d2a3

📥 Commits

Reviewing files that changed from the base of the PR and between 6477873 and af4467c.

📒 Files selected for processing (4)
  • MIGRATIONS.md
  • src/modules/billing/config/billing.static-content.js
  • src/modules/core/components/core.pageTabs.component.vue
  • src/modules/core/tests/core.pageTabs.component.unit.tests.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/cleanup-dead-pagetabs-doc-drift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an unused core tab component introduced in an earlier refactor, and cleans up documentation/comment drift caused by the vue-i18n removal and the subsequent tab-bar consolidation.

Changes:

  • Deleted orphan core.pageTabs component and its unit test.
  • Updated MIGRATIONS.md to note the removal and to strike/supersede a stale src/lib/plugins/i18n.js reference.
  • Updated JSDoc/comments in billing.static-content.js to replace stale “fallback to i18n” wording with English-default behavior notes.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/modules/core/tests/core.pageTabs.component.unit.tests.js Removes the unit test for the now-deleted orphan core.pageTabs component.
src/modules/core/components/core.pageTabs.component.vue Deletes the unused CorePageTabs implementation (superseded by CoreSurfaceTabBar).
src/modules/billing/config/billing.static-content.js Updates doc comments describing runtime fallback behavior after i18n removal.
MIGRATIONS.md Adds a migration note for dropping core.pageTabs and marks an i18n-plugin reference as superseded.

Comment thread src/modules/billing/config/billing.static-content.js
Comment thread src/modules/billing/config/billing.static-content.js
Comment thread src/modules/billing/config/billing.static-content.js
Comment thread MIGRATIONS.md Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.56%. Comparing base (6477873) to head (af4467c).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4192   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          31       31           
  Lines        1140     1140           
  Branches      329      329           
=======================================
  Hits         1135     1135           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PierreBrisorgueil
Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

…ccuracy (CR)

- MIGRATIONS.md: replace SurfaceTabBar → CoreSurfaceTabBar, make downstream
  deletion paths explicit (vue + test file separately)
- static-content.js faqs @type: add string|null to subtitle, describe falsy fallback
- static-content.js tabs: clarify two-layer fallback (devkit default 'Extras'
  vs view hardcoded 'Units' when field absent/falsy)
- static-content.js header: wording updated to 'any falsy value (including
  empty string) triggers view fallback'
@PierreBrisorgueil PierreBrisorgueil merged commit c053c37 into master May 22, 2026
7 checks passed
@PierreBrisorgueil PierreBrisorgueil deleted the chore/cleanup-dead-pagetabs-doc-drift branch May 22, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants