feat(auth): add beta seat getters (signupCap/seatsRemaining/betaCapped)#4229
Conversation
Expose signupCap, seatsRemaining, betaCapped getters derived from serverConfig.sign.* — null-safe, inert when no cap is configured.
|
Warning Review limit reached
More reviews will be available in 59 minutes and 57 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds three null-safe getters to the auth Pinia store to expose beta signup capacity information (signupCap, seatsRemaining, betaCapped) derived from serverConfig.sign.*, along with unit tests validating capped/uncapped/missing-config behavior.
Changes:
- Added
signupCap,seatsRemaining, andbetaCappedgetters toauth.store.js. - Added unit tests covering uncapped, capped, and missing
serverConfigscenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/modules/auth/stores/auth.store.js | Introduces new beta seat/cap getters on the auth store. |
| src/modules/auth/tests/auth.store.unit.tests.js | Adds unit tests to validate the new getters’ null-safety and behavior. |
| // Beta capacity from the public auth config: cap/remaining are null when uncapped; betaCapped is true only when a numeric cap is set. | ||
| signupCap: (state) => state.serverConfig?.sign?.cap ?? null, | ||
| seatsRemaining: (state) => state.serverConfig?.sign?.remaining ?? null, | ||
| betaCapped: (state) => state.serverConfig?.sign?.cap != null, |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4229 +/- ##
=======================================
Coverage 99.56% 99.56%
=======================================
Files 31 31
Lines 1159 1162 +3
Branches 327 329 +2
=======================================
+ Hits 1154 1157 +3
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What
Adds three null-safe Pinia getters to the auth store —
signupCap,seatsRemaining,betaCapped— readingserverConfig.sign.{cap,remaining}(populated by the upstreamGET /api/auth/configresponse). No action/state/fetch changes.Why
Upstream-generic half of a downstream private-beta invite gate. Downstream landing components read these getters to render a "Beta · X seats left" banner; exposing typed getters avoids reaching into
serverConfig.sign.*raw.Inert by default
For any downstream without a configured cap, all three return null/false. Pairs with the devkit Node
/auth/configchange (contract: Node adds the fields, Vue reads them).Tests
3 unit tests (uncapped, capped, missing serverConfig). Lint clean.
🤖 Generated with Claude Code