Skip to content

fix(skills/update-stack): switch drift gate scan to git diff (catches missing-locally case)#4244

Merged
PierreBrisorgueil merged 1 commit into
masterfrom
fix/drift-gate-scan-source-flip
Jun 3, 2026
Merged

fix(skills/update-stack): switch drift gate scan to git diff (catches missing-locally case)#4244
PierreBrisorgueil merged 1 commit into
masterfrom
fix/drift-gate-scan-source-flip

Conversation

@PierreBrisorgueil
Copy link
Copy Markdown
Collaborator

Summary

  • Replaces git ls-files src/modules src/lib src/config iteration (locally-present files only) with git diff --name-only devkit-vue/master HEAD (bidirectional diff)
  • Adds a second BLOCK arm: files present upstream but absent locally → BLOCK: missing locally (was on upstream) with a restore hint
  • Downstream-only files (not in upstream) are still skipped silently
  • Updates the Rules bullet to explain why git diff was chosen over git ls-files

Root cause

The old gate iterated git ls-files which only enumerates files that exist in the working tree. A file deleted from a downstream (but still in upstream) was silently skipped — the gate could never detect the "missing locally" case.

Test plan

  • Smoke: bash -c '...' on the gate block — exits 0 on clean tree
  • Verify the gate runs to 3ter: no drift — OK on a clean downstream after /update-stack
  • Manually delete a stack file locally, re-run gate → should BLOCK with missing locally message

Closes #4233

… missing-locally case)

Replace `git ls-files` iteration (locally-present files only) with
`git diff --name-only devkit-vue/master HEAD` (bidirectional). Adds
a second BLOCK arm for files present upstream but absent locally —
the previous scan silently skipped deleted stack files.

Closes #4233
Copilot AI review requested due to automatic review settings June 3, 2026 14:59
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Warning

Review limit reached

@PierreBrisorgueil, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 57 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4dfa2335-7f9a-40d0-9db1-8491c4d9c135

📥 Commits

Reviewing files that changed from the base of the PR and between 54358f0 and 01240ce.

📒 Files selected for processing (1)
  • .claude/skills/update-stack/SKILL.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/drift-gate-scan-source-flip

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the /update-stack “3ter. Block on drift” gate in .claude/skills/update-stack/SKILL.md to source its scan list from git diff --name-only devkit-vue/master HEAD instead of iterating locally-present files via git ls-files, with the goal of also catching “present upstream but missing locally” cases.

Changes:

  • Switches the drift scan input list from git ls-files … to git diff --name-only devkit-vue/master HEAD -- … to include upstream-vs-local deletions.
  • Adds an explicit BLOCK branch for “missing locally (was on upstream)” with a suggested restore command.
  • Updates the documented Rules to explain why git diff was chosen.

Comment on lines +118 to 119
done < <(git diff --name-only devkit-vue/master HEAD -- src/modules src/lib src/config 2>/dev/null \
| grep -vE "/(tests|__tests__)/" | grep -vE "\.(test|spec)\.(js|jsx|ts|tsx|vue)$")
@PierreBrisorgueil PierreBrisorgueil merged commit 32bd2d3 into master Jun 3, 2026
4 checks passed
@PierreBrisorgueil PierreBrisorgueil deleted the fix/drift-gate-scan-source-flip branch June 3, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(skills/update-stack): switch drift gate scan source from local git ls-files to upstream git ls-tree

2 participants