fix(embedded): restore PilotEmbeddedStart (web4 PR #155 merged)#18
Merged
Merged
Conversation
PR #155 (satisfy daemonapi.Daemon via adapter) landed on web4 main as 6c45b716, making d.DaemonAPI() available. This commit removes the stub error and wires the real boot path: daemon.New → DaemonAPI() → runtime.New → register trustedagents/handshake/policy plugins → StartPlugins → Start. go.mod promotes handshake, policy, trustedagents to direct dependencies and picks up minor upstream bumps (common v0.5.5, coder/websocket v1.8.15, golang.org/x/sys v0.46.0) from go mod tidy. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
This currently has a merge conflict and can't be cleanly merged. A rebase on |
Resolve conflicts preserving the restored PilotEmbeddedStart embedded API and the org rename, while taking main's newer dependency versions. - go.mod: union of requires; keep common v0.5.5 (no downgrade to v0.4.8), keep handshake/policy as direct deps used by PilotEmbeddedStart; go directive bumped to 1.25.11 via go mod tidy (sibling drift). - embedded.go: keep crypto/handshake/policy imports needed by the restored PilotEmbeddedStart; gofmt the daemon.Config struct alignment. - .github/workflows/ci.yml: keep main's CI plus the pilot-protocol rename.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
d.DaemonAPI()availableerrJSON(\"embedded daemon not implemented yet\")and wires the real boot path:daemon.New→DaemonAPI()→runtime.New→ register trustedagents/handshake/policy plugins →StartPlugins→d.Start()address,node_id,public_key,socketas documented in the function commentgo mod tidypromotes handshake, policy, trustedagents to direct deps and picks up minor upstream bumps (common v0.5.5, websocket v1.8.15, sys v0.46.0)Test plan
go build ./...passes (verified locally — zero compiler errors)PilotEmbeddedStartno longer returns the stub error at runtimePilotEmbeddedStopstill tears down daemon + plugins correctly (code path unchanged)PilotEmbeddedStartwith a valid config, verify node registers🤖 Generated with Claude Code