Remove dead updatePoloScores, add nameserver cleanup

- Remove unused Daemon.updatePoloScores (replaced by inline logic in
  handleTaskResults)
- Add defer ns.Close() to all nameserver integration tests

Author: teovl

pkg/daemon/services.go

@@ -1113,36 +1113,3 @@ func (d *Daemon) handleTaskResults(adapter *connAdapter, conn *Connection, frame
 	}
 }
 
-// updatePoloScores updates polo scores for task processing.
-func (d *Daemon) updatePoloScores(receiverNode, submitterNode uint32) {
-	if d.regConn == nil {
-		slog.Warn("tasksubmit: cannot update polo score, no registry connection")
-		return
-	}
-
-	// Receiver gets +1 polo score
-	if _, err := d.regConn.UpdatePoloScore(receiverNode, 1); err != nil {
-		slog.Warn("tasksubmit: failed to update receiver polo score",
-			"node_id", receiverNode,
-			"error", err,
-		)
-	} else {
-		slog.Info("tasksubmit: polo score updated",
-			"node_id", receiverNode,
-			"delta", 1,
-		)
-	}
-
-	// Submitter gets -1 polo score
-	if _, err := d.regConn.UpdatePoloScore(submitterNode, -1); err != nil {
-		slog.Warn("tasksubmit: failed to update submitter polo score",
-			"node_id", submitterNode,
-			"error", err,
-		)
-	} else {
-		slog.Info("tasksubmit: polo score updated",
-			"node_id", submitterNode,
-			"delta", -1,
-		)
-	}
-}

tests/nameserver_test.go

@@ -35,6 +35,7 @@ func TestNameserver(t *testing.T) {
 	ns := nameserver.New(a.Driver, "")
 	go ns.ListenAndServe()
 	waitNSReady(t, ns)
+	defer ns.Close()
 
 	// Pre-register some records directly
 	ns.Store().RegisterA("agent-alpha", a.Daemon.Addr())
@@ -114,6 +115,7 @@ func TestNameserverSRecord(t *testing.T) {
 	ns := nameserver.New(a.Driver, "")
 	go ns.ListenAndServe()
 	waitNSReady(t, ns)
+	defer ns.Close()
 
 	client := nameserver.NewClient(b.Driver, a.Daemon.Addr())
 
@@ -157,6 +159,7 @@ func TestNameserverRegisterN(t *testing.T) {
 	ns := nameserver.New(a.Driver, "")
 	go ns.ListenAndServe()
 	waitNSReady(t, ns)
+	defer ns.Close()
 
 	client := nameserver.NewClient(b.Driver, a.Daemon.Addr())
 
@@ -188,6 +191,7 @@ func TestNameserverOverwriteA(t *testing.T) {
 	ns := nameserver.New(a.Driver, "")
 	go ns.ListenAndServe()
 	waitNSReady(t, ns)
+	defer ns.Close()
 
 	client := nameserver.NewClient(b.Driver, a.Daemon.Addr())
 
@@ -228,6 +232,7 @@ func TestNameserverPersistence(t *testing.T) {
 	ns1 := nameserver.New(a.Driver, storePath)
 	go ns1.ListenAndServe()
 	waitNSReady(t, ns1)
+	defer ns1.Close()
 
 	client := nameserver.NewClient(b.Driver, a.Daemon.Addr())
 
@@ -280,6 +285,7 @@ func TestNameserverMultipleClients(t *testing.T) {
 	ns := nameserver.New(a.Driver, "")
 	go ns.ListenAndServe()
 	waitNSReady(t, ns)
+	defer ns.Close()
 
 	// Pre-register
 	ns.Store().RegisterA("target", a.Daemon.Addr())