fix: inject nodeID into telemetry events and add catalogue_viewed payload (#281)

- pkg/telemetry/client.go: Send() now injects c.nodeID into events
  that don't supply their own NodeID, so telemetry events carry the
  correct node identity instead of always being 0
- cmd/pilotctl/appstore_catalogue.go: catalogue_viewed event now sends
  payload {"surface":"catalogue"} instead of empty {}

Co-authored-by: Teodor Calin <teodor@vulturelabs.io>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: 3 people

cmd/pilotctl/appstore_catalogue.go

@@ -248,8 +248,9 @@ func cmdAppStoreCatalogue(_ []string) {
 		identityPath := configDir() + "/identity.json"
 		client := telemetry.NewClientFromIdentity(url, identityPath, 0)
 		err := client.Send(telemetry.Event{
-			Kind: "catalogue_viewed",
-			TS:   time.Now().UTC().Format(time.RFC3339),
+			Kind:    "catalogue_viewed",
+			TS:      time.Now().UTC().Format(time.RFC3339),
+			Payload: json.RawMessage(`{"surface":"catalogue"}`),
 		})
 		if err != nil {
 			slog.Warn("telemetry send failed, catalogue still rendered", "err", err)

pkg/telemetry/client.go

@@ -98,6 +98,7 @@ func (c *Client) Send(events ...Event) error {
 	url := c.url
 	sign := c.sign
 	pubKeyB := c.pubKeyB
+	nodeID := c.nodeID
 	c.mu.Unlock()
 
 	if disabled || url == "" {
@@ -113,6 +114,15 @@ func (c *Client) Send(events ...Event) error {
 		return nil
 	}
 
+	// Inject node ID into events that don't supply their own.
+	if nodeID != 0 {
+		for i := range events {
+			if events[i].NodeID == 0 {
+				events[i].NodeID = nodeID
+			}
+		}
+	}
+
 	body, err := json.Marshal(events)
 	if err != nil {
 		return fmt.Errorf("telemetry marshal: %w", err)