Fix CI: update tests for simplified dashboard, fix Node SDK publish

- Remove references to DashboardStats.Nodes, Edges, UniqueTags,
  TaskExecutors in tests (fields removed in dashboard simplification)
- Add npm ci before npm publish in Node SDK workflow so tsc can
  find @types/node during prepublishOnly

Author: teovl

.github/workflows/publish-node-sdk.yml

@@ -217,6 +217,8 @@ jobs:
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
         run: |
+          # Install dependencies so prepublishOnly (tsc) can find @types/node
+          npm ci
           # Publish with linux tag
           if [ "${{ needs.setup.outputs.environment }}" = "test" ]; then
             npm publish --tag dev --access public

tests/dashboard_test.go

@@ -94,22 +94,12 @@ func TestDashboardStatsWithNodes(t *testing.T) {
 	if stats.TotalRequests < 2 {
 		t.Fatalf("expected at least 2 requests, got %d", stats.TotalRequests)
 	}
-	if len(stats.Nodes) != 2 {
-		t.Fatalf("expected 2 nodes in list, got %d", len(stats.Nodes))
+	// Nodes registered without a version should appear as "<1.7.0"
+	if stats.Versions == nil {
+		t.Fatal("expected non-nil Versions map")
 	}
-
-	// Verify no IPs leak in addresses
-	for _, node := range stats.Nodes {
-		if strings.Contains(node.Address, "127.0.0.1") {
-			t.Fatalf("node address should be a pilot address, not an IP: %s", node.Address)
-		}
-	}
-
-	// Verify node addresses are pilot addresses (not IPs)
-	for _, node := range stats.Nodes {
-		if strings.Contains(node.Address, "127.0.0.1") {
-			t.Fatalf("node address should be a pilot address, not IP: %s", node.Address)
-		}
+	if stats.Versions["<1.7.0"] != 2 {
+		t.Fatalf("expected 2 nodes with version <1.7.0, got %d", stats.Versions["<1.7.0"])
 	}
 }
 

tests/fuzz_registry_server_test.go

@@ -163,12 +163,6 @@ func TestRegistryServerDashboardStatsEmpty(t *testing.T) {
 	if stats.TotalRequests != 0 {
 		t.Fatalf("expected 0 requests, got %d", stats.TotalRequests)
 	}
-	if stats.UniqueTags != 0 {
-		t.Fatalf("expected 0 unique tags, got %d", stats.UniqueTags)
-	}
-	if stats.TaskExecutors != 0 {
-		t.Fatalf("expected 0 task executors, got %d", stats.TaskExecutors)
-	}
 	if stats.UptimeSecs < 0 {
 		t.Fatalf("uptime should be non-negative, got %d", stats.UptimeSecs)
 	}
@@ -594,8 +588,8 @@ func TestRegistryClientSetTags(t *testing.T) {
 	}
 
 	stats := s.GetDashboardStats()
-	if stats.UniqueTags < 1 {
-		t.Fatal("expected at least 1 unique tag")
+	if stats.TotalNodes < 1 {
+		t.Fatal("expected at least 1 node after tag set")
 	}
 }
 
@@ -1280,8 +1274,8 @@ func TestRegistryClientSetTaskExec(t *testing.T) {
 	}
 
 	stats := s.GetDashboardStats()
-	if stats.TaskExecutors != 1 {
-		t.Fatalf("expected 1 task executor, got %d", stats.TaskExecutors)
+	if stats.TotalNodes != 1 {
+		t.Fatalf("expected 1 node, got %d", stats.TotalNodes)
 	}
 }
 

tests/snapshot_test.go

@@ -346,8 +346,6 @@ func TestSnapshotSaveLoad(t *testing.T) {
 	t.Logf("  Total Requests: %d", statsBefore.TotalRequests)
 	t.Logf("  Total Nodes: %d", statsBefore.TotalNodes)
 	t.Logf("  Active Nodes: %d", statsBefore.ActiveNodes)
-	t.Logf("  Unique Tags: %d", statsBefore.UniqueTags)
-	t.Logf("  Task Executors: %d", statsBefore.TaskExecutors)
 	t.Logf("  Uptime: %d seconds", statsBefore.UptimeSecs)
 
 	// Trigger snapshot
@@ -413,8 +411,6 @@ func TestSnapshotSaveLoad(t *testing.T) {
 	t.Logf("  Total Requests: %d", statsAfter.TotalRequests)
 	t.Logf("  Total Nodes: %d", statsAfter.TotalNodes)
 	t.Logf("  Active Nodes: %d", statsAfter.ActiveNodes)
-	t.Logf("  Unique Tags: %d", statsAfter.UniqueTags)
-	t.Logf("  Task Executors: %d", statsAfter.TaskExecutors)
 	t.Logf("  Trust Links: %d", statsAfter.TotalTrustLinks)
 	t.Logf("  Uptime: %d seconds", statsAfter.UptimeSecs)
 
@@ -427,37 +423,8 @@ func TestSnapshotSaveLoad(t *testing.T) {
 		t.Errorf("TotalNodes not restored: before=%d, after=%d",
 			statsBefore.TotalNodes, statsAfter.TotalNodes)
 	}
-	if statsAfter.UniqueTags != statsBefore.UniqueTags {
-		t.Errorf("UniqueTags not restored: before=%d, after=%d",
-			statsBefore.UniqueTags, statsAfter.UniqueTags)
-	}
-	if statsAfter.TaskExecutors != statsBefore.TaskExecutors {
-		t.Errorf("TaskExecutors not restored: before=%d, after=%d",
-			statsBefore.TaskExecutors, statsAfter.TaskExecutors)
-	}
-
-	// Validate nodes are restored
-	if len(statsAfter.Nodes) != 3 {
-		t.Errorf("expected 3 nodes, got %d", len(statsAfter.Nodes))
-	}
-
-	// Validate POLO scores are restored
-	poloScores := make(map[int]bool)
-	for _, node := range statsAfter.Nodes {
-		poloScores[node.PoloScore] = true
-	}
-	expectedScores := []int{150, 45, 92}
-	for _, score := range expectedScores {
-		if !poloScores[score] {
-			t.Errorf("POLO score %d not found in restored nodes", score)
-		}
-	}
-
-	// Validate online status (nodes should be stale after restart)
-	for _, node := range statsAfter.Nodes {
-		if node.Online {
-			t.Logf("Warning: node %s is online after restart (might be ok)", node.Address)
-		}
+	if statsAfter.TotalNodes != 3 {
+		t.Errorf("expected 3 nodes, got %d", statsAfter.TotalNodes)
 	}
 
 	t.Logf("\n✅ Snapshot save/load test passed")

tests/tags_test.go

@@ -290,14 +290,8 @@ func TestSetTagsDashboardAPI(t *testing.T) {
 		t.Fatalf("decode JSON: %v", err)
 	}
 
-	if len(stats.Nodes) != 1 {
-		t.Fatalf("expected 1 node, got %d", len(stats.Nodes))
-	}
-	if len(stats.Nodes[0].Tags) != 2 {
-		t.Fatalf("expected 2 tags, got %d: %v", len(stats.Nodes[0].Tags), stats.Nodes[0].Tags)
-	}
-	if stats.UniqueTags != 2 {
-		t.Fatalf("expected 2 unique tags, got %d", stats.UniqueTags)
+	if stats.TotalNodes != 1 {
+		t.Fatalf("expected 1 node, got %d", stats.TotalNodes)
 	}
 }
 

tests/task_exec_test.go

@@ -228,14 +228,8 @@ func TestSetTaskExecDashboardAPI(t *testing.T) {
 		t.Fatalf("decode JSON: %v", err)
 	}
 
-	if stats.TaskExecutors != 1 {
-		t.Fatalf("expected 1 task executor, got %d", stats.TaskExecutors)
-	}
-	if len(stats.Nodes) != 1 {
-		t.Fatalf("expected 1 node, got %d", len(stats.Nodes))
-	}
-	if !stats.Nodes[0].TaskExec {
-		t.Fatal("expected node task_exec=true in dashboard")
+	if stats.TotalNodes != 1 {
+		t.Fatalf("expected 1 node, got %d", stats.TotalNodes)
 	}
 }