fix(appstore): always show view pointer in catalogue listing (PILOT-405)#274
Closed
matthew-pilot wants to merge 1 commit into
Closed
fix(appstore): always show view pointer in catalogue listing (PILOT-405)#274matthew-pilot wants to merge 1 commit into
matthew-pilot wants to merge 1 commit into
Conversation
The catalog list now unconditionally prints the view pointer for every entry, even without extended metadata. The view command works from the catalogue entry alone. Closes PILOT-405
Collaborator
|
Closing — superseded by a merged PR for the same ticket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The
pilotctl appstore cataloguelist now always prints theview: pilotctl appstore view <id>pointer for every entry, regardless of whether the catalogue entry has extended metadata pinned.Why
Previously the view pointer was conditional on
e.MetadataURL != "", which meant entries without a detail-doc pin silently omitted the "view" option. Theviewcommand works from the catalogue entry alone (showing teaser fields) and degrades gracefully — it should always be discoverable.Verification
go build ./cmd/pilotctl/— cleango vet ./cmd/pilotctl/— cleango test -run "AppStore|Catalogue|catalogue|cat" ./cmd/pilotctl/— passCloses PILOT-405