Drop push-based downstream fan-out in favor of self-polling#323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
publish-downstreamjob fromrelease.yml(added in #322). The release workflow is back to: test → build binaries → create GitHub Release. A comment in its place points to the new self-updating downstream watchers.Why
publish-downstreamdispatched the SDKpublish.ymlworkflows and pushed the Homebrew formula from here, which required cross-repo PATs (RELEASE_DISPATCH_TOKEN,HOMEBREW_TAP_TOKEN) — a workflow's built-inGITHUB_TOKENcan't write to sibling repos. Without those PATs the job's gate step fails every release.Each downstream now pulls instead of being pushed to, polling this repo's public latest release on a schedule and acting with its own token:
TeoSlayer/homebrew-pilot→update-formula.yml(ownGITHUB_TOKEN)pilot-protocol/sdk-node→release-watch.yml→ ownpublish.yml(NPM_TOKEN)pilot-protocol/sdk-python→release-watch.yml→ ownpublish.yml(PYPI_API_TOKEN)Net result: zero cross-repo PATs anywhere in the pipeline. Binary build + GitHub Release logic is untouched.
Validated:
actionlintreports the same 7 pre-existing shellcheck infos as before (zero new), all in the untouched build/release scripts.