Skip to content

[Bug] Asset folder preview: trigger generation of preview on request #1101

Open
brusch wants to merge 1 commit into2.3from
asset-folder-preview-fix
Open

[Bug] Asset folder preview: trigger generation of preview on request #1101
brusch wants to merge 1 commit into2.3from
asset-folder-preview-fix

Conversation

@brusch
Copy link
Copy Markdown
Member

@brusch brusch commented Mar 23, 2026

fixes #1096

@brusch brusch added this to the 2.3.2 milestone Mar 23, 2026
Copilot AI review requested due to automatic review settings March 23, 2026 08:50
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes missing async generation trigger for asset folder content previews by ensuring preview generation is dispatched when a tree-preview thumbnail is requested but not yet available.

Changes:

  • Always dispatch AssetPreviewImageMessage when treepreview is requested and the preview thumbnail does not exist (not just for origin=treeNode).
  • Keep existing origin-specific responses (404 for treeNode, loading GIF for folderPreview) while triggering generation.
Comments suppressed due to low confidence (1)

src/Controller/Admin/Asset/AssetController.php:1181

  • getFolderContentPreviewAction() builds preview URLs for all non-folder assets with origin=folderPreview (via ElementService::getThumbnailUrl()), but only the image thumbnail endpoint dispatches AssetPreviewImageMessage for folderPreview. The video and document thumbnail endpoints still dispatch only for origin=treeNode, so folderPreview requests won’t enqueue preview generation when those thumbnails are missing. Consider aligning getVideoThumbnailAction() / getDocumentThumbnailAction() with the image behavior (dispatch + placeholder/appropriate response) or otherwise ensuring folder previews can self-trigger generation for those asset types too.
                \Pimcore::getContainer()->get('messenger.bus.pimcore-core')->dispatch(
                    new AssetPreviewImageMessage($image->getId())
                );

                if ($request->get('origin') === 'treeNode') {
                    throw $this->createNotFoundException(sprintf('Tree preview thumbnail not available for asset %s', $image->getId()));
                } elseif ($request->get('origin') === 'folderPreview') {
                    return new BinaryFileResponse(PIMCORE_WEB_ROOT . '/bundles/pimcoreadmin/img/video-loading.gif');
                }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@berfinyuksel berfinyuksel modified the milestones: 2.3.2, 2.3.3, 2.3.4 Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Asset Previews never generated

5 participants