[Bug] Asset folder preview: trigger generation of preview on request #1101
Open
[Bug] Asset folder preview: trigger generation of preview on request #1101
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes missing async generation trigger for asset folder content previews by ensuring preview generation is dispatched when a tree-preview thumbnail is requested but not yet available.
Changes:
- Always dispatch
AssetPreviewImageMessagewhentreepreviewis requested and the preview thumbnail does not exist (not just fororigin=treeNode). - Keep existing
origin-specific responses (404 fortreeNode, loading GIF forfolderPreview) while triggering generation.
Comments suppressed due to low confidence (1)
src/Controller/Admin/Asset/AssetController.php:1181
getFolderContentPreviewAction()builds preview URLs for all non-folder assets withorigin=folderPreview(viaElementService::getThumbnailUrl()), but only the image thumbnail endpoint dispatchesAssetPreviewImageMessageforfolderPreview. The video and document thumbnail endpoints still dispatch only fororigin=treeNode, sofolderPreviewrequests won’t enqueue preview generation when those thumbnails are missing. Consider aligninggetVideoThumbnailAction()/getDocumentThumbnailAction()with the image behavior (dispatch + placeholder/appropriate response) or otherwise ensuring folder previews can self-trigger generation for those asset types too.
\Pimcore::getContainer()->get('messenger.bus.pimcore-core')->dispatch(
new AssetPreviewImageMessage($image->getId())
);
if ($request->get('origin') === 'treeNode') {
throw $this->createNotFoundException(sprintf('Tree preview thumbnail not available for asset %s', $image->getId()));
} elseif ($request->get('origin') === 'folderPreview') {
return new BinaryFileResponse(PIMCORE_WEB_ROOT . '/bundles/pimcoreadmin/img/video-loading.gif');
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



… fixes #1096