Fix setup-matrix checkout to use PR base branch ref#596
Open
berfinyuksel wants to merge 2 commits into2026.xfrom
Open
Fix setup-matrix checkout to use PR base branch ref#596berfinyuksel wants to merge 2 commits into2026.xfrom
berfinyuksel wants to merge 2 commits into2026.xfrom
Conversation
On pull_request_target, the checkout was reading composer.json from the default branch instead of the PR's target branch, causing wrong PHP versions in the test matrix.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On pull_request_target, the checkout was reading composer.json from the default branch instead of the PR's target branch, causing wrong PHP versions in the test matrix.
Changes in this pull request
Resolves #
Additional info