[BUG] Adds normalize to boolean adapter#434
Open
Jonathon-Meney-Torq wants to merge 1 commit into
Open
Conversation
|
mcop1
reviewed
Jul 9, 2026
Comment on lines
+30
to
+33
| public function normalize(mixed $value): mixed | ||
| { | ||
| return $value !== null ? (bool) $value : null; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| public function normalize(mixed $value): mixed | |
| { | |
| return $value !== null ? (bool) $value : null; | |
| } | |
| public function normalize(mixed $value): mixed | |
| { | |
| if ($value === null) { | |
| return null; | |
| } | |
| if ($this->fieldDefinition instanceof BooleanSelect) { | |
| return $this->fieldDefinition->getDataFromResource($value); | |
| } | |
| return (bool) $value; | |
| } |
The boolean adapter is also registered for booleanSelect, which has a 3 states. Maybe something like this would be better? What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Fixes issue where checkbox classification store keys would fail on index update as value was being read as string instead of boolean.
Additional info
On a typical class definition a boolean field would be a tinyint and there of the correctly expected type. A classification store value is stored as a longtext and there fore interpreted as a string.