Return non-zero exit code for cleanup command exceptions

[Copilot]

The review comment highlighted that generic-data-index:cleanup:unused-indices reported success even when cleanup failed, which breaks automation expecting reliable exit status semantics. This change makes failure observable by returning a non-zero code from the exception path.

• Behavior change

  • Updated CleanupUnusedIndicesCommand::execute() to return self::FAILURE when an exception is caught, instead of falling through to self::SUCCESS.

• Operational impact

  • Cron/CI/K8s job runners can now correctly detect failed cleanup runs and trigger retry/alert logic based on process exit code.

} catch (Exception $e) {
    $output->writeln('<error>' . $e->getMessage() . '</error>');
    return self::FAILURE;
} finally {
    $this->release();
}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud