Closed
fix: let exceptions bubble up from getAllManagedIndices() instead of silently returning empty#442
Conversation
- add generic-data-index:cleanup:unused-indices command - default behavior deletes unmanaged stale -odd/-even indices not referenced by aliases - add --dry-run option to preview deletions without changes - implement UnusedIndexCleanupService to detect candidates via prefix + alias diff - add unit tests for selection, dry-run, and execute behavior - document new cleanup command in index management docs
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix the code for review comment in PR #391
fix: let exceptions bubble up from getAllManagedIndices() instead of silently returning empty
Jun 23, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




getAllManagedIndices()was swallowing all exceptions fromgetStats()and returning[], causing the cleanup command to silently report "No unused indices found" on connection/auth failures — masking real operational problems.Changes
UnusedIndexCleanupService::getAllManagedIndices()— removed thecatch (Exception)block; exceptions fromSearchIndexServiceInterface::getStats()now propagate up toCleanupUnusedIndicesCommand::execute(), which already handles them by writing the error message to outputdoc/02_Configuration/03_Index_Management.md— resolved merge conflict, keeping improved wording from base branch while retaining the Cleanup Unused Indices section introduced by the PR