Skip to content

docs: clarify cleanup command only targets -odd/-even managed indices#443

Closed
kingjia90 with Copilot wants to merge 3 commits into
2026.xfrom
copilot/fix-code-review-suggestion
Closed

docs: clarify cleanup command only targets -odd/-even managed indices#443
kingjia90 with Copilot wants to merge 3 commits into
2026.xfrom
copilot/fix-code-review-suggestion

Conversation

Copilot AI commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

The "Cleaning Up Unused Indices" docs section described the command as removing "old indices not referenced by any alias" — misleading users into thinking any unaliased index under the prefix would be removed.

Changes

  • doc/02_Configuration/03_Index_Management.md — Rewrites the section description to explicitly state only managed indices with -odd/-even suffixes under the configured prefix are targeted; adds a > Note: callout clarifying custom indices without the suffix are unaffected
  • src/Command/CleanupUnusedIndicesCommand.php — Updates setDescription and adds setHelp to match the narrower scope
  • src/Service/SearchIndex/UnusedIndexCleanupService.php — Guards against empty indexPrefix (would otherwise produce * and match all indices)

Copilot AI changed the title [WIP] Fix code based on review comment docs: clarify cleanup command only targets -odd/-even managed indices Jun 23, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
2 New Major Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copilot AI requested a review from kingjia90 June 23, 2026 11:10
@kingjia90 kingjia90 closed this Jun 24, 2026
@kingjia90 kingjia90 deleted the copilot/fix-code-review-suggestion branch June 24, 2026 08:31
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants