Closed
Propagate stats retrieval failures in unused-index cleanup service#447
Conversation
|
Copilot
AI
changed the title
[WIP] Fix code based on review comment
Propagate stats retrieval failures in unused-index cleanup service
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR addresses the review feedback on
discussion_r3303031990:UnusedIndexCleanupService::getAllManagedIndices()was swallowinggetStats()exceptions and returning an empty result, which could falsely report “no unused indices.”The change makes stats failures explicit by letting exceptions propagate to command-level error handling.
Service behavior change
UnusedIndexCleanupService::getAllManagedIndices().SearchIndexServiceInterface::getStats()failures now bubble up instead of being converted to[].Focused unit coverage
findUnusedIndices()propagates a thrown stats exception.