Skip to content

Commit 51d9364

Browse files
authored
fix: preview thumbnail return type (#956)
1 parent 77eebbd commit 51d9364

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

src/Asset/Service/ThumbnailService.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,12 @@
3030
use Pimcore\Bundle\StudioBackendBundle\Util\Constant\Thumbnails;
3131
use Pimcore\Bundle\StudioBackendBundle\Util\Trait\ConsoleExecutableTrait;
3232
use Pimcore\Model\Asset\Document;
33+
use Pimcore\Model\Asset\Document\ImageThumbnailInterface as DocumentThumbnail;
3334
use Pimcore\Model\Asset\Image;
3435
use Pimcore\Model\Asset\Image\Thumbnail\Config as ImageThumbnailConfig;
3536
use Pimcore\Model\Asset\Image\ThumbnailInterface;
3637
use Pimcore\Model\Asset\Video;
37-
use Pimcore\Model\Asset\Video\ImageThumbnailInterface;
38+
use Pimcore\Model\Asset\Video\ImageThumbnailInterface as VideoImageThumbnail;
3839
use Pimcore\Model\Asset\Video\Thumbnail\Config as VideoThumbnailConfig;
3940
use Symfony\Component\HttpFoundation\BinaryFileResponse;
4041
use Symfony\Component\HttpFoundation\ResponseHeaderBag;
@@ -109,7 +110,7 @@ public function getImagePreviewThumbnail(Image $image): ThumbnailInterface
109110
/**
110111
* @throws InvalidThumbnailException
111112
*/
112-
public function getAssetImagePreviewThumbnail(Video|Document $asset): ImageThumbnailInterface
113+
public function getAssetImagePreviewThumbnail(Video|Document $asset): DocumentThumbnail|VideoImageThumbnail
113114
{
114115
$thumbnailConfig = $this->getSystemImageThumbnailConfig();
115116
if ($thumbnailConfig === null) {

src/Asset/Service/ThumbnailServiceInterface.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,11 @@
2222
use Pimcore\Bundle\StudioBackendBundle\Exception\Api\InvalidThumbnailException;
2323
use Pimcore\Bundle\StudioBackendBundle\Exception\Api\ThumbnailResizingFailedException;
2424
use Pimcore\Model\Asset\Document;
25+
use Pimcore\Model\Asset\Document\ImageThumbnailInterface as DocumentThumbnail;
2526
use Pimcore\Model\Asset\Image;
2627
use Pimcore\Model\Asset\Image\ThumbnailInterface;
2728
use Pimcore\Model\Asset\Video;
28-
use Pimcore\Model\Asset\Video\ImageThumbnailInterface;
29+
use Pimcore\Model\Asset\Video\ImageThumbnailInterface as VideoImageThumbnail;
2930
use Pimcore\Model\Asset\Video\Thumbnail\Config as VideoThumbnailConfig;
3031
use Symfony\Component\HttpFoundation\BinaryFileResponse;
3132

@@ -56,7 +57,7 @@ public function getImagePreviewThumbnail(Image $image): ThumbnailInterface;
5657
/**
5758
* @throws InvalidThumbnailException
5859
*/
59-
public function getAssetImagePreviewThumbnail(Video|Document $asset): ImageThumbnailInterface;
60+
public function getAssetImagePreviewThumbnail(Video|Document $asset): DocumentThumbnail|VideoImageThumbnail;
6061

6162
/**
6263
* @throws InvalidThumbnailException

0 commit comments

Comments
 (0)