[Data Object Creation] Catch duplicate full path exception (#920)

* Replaced generic exception with more specific exception

* Apply php-cs-fixer changes

* Added method to interface

Author: mcop1

src/DataObject/Service/DataObjectService.php

@@ -32,6 +32,7 @@
 use Pimcore\Bundle\StudioBackendBundle\DataObject\Util\Trait\ValidateObjectDataTrait;
 use Pimcore\Bundle\StudioBackendBundle\Element\Service\ElementSaveServiceInterface;
 use Pimcore\Bundle\StudioBackendBundle\Exception\Api\DatabaseException;
+use Pimcore\Bundle\StudioBackendBundle\Exception\Api\ElementExistsException;
 use Pimcore\Bundle\StudioBackendBundle\Exception\Api\ElementSavingFailedException;
 use Pimcore\Bundle\StudioBackendBundle\Exception\Api\ForbiddenException;
 use Pimcore\Bundle\StudioBackendBundle\Exception\Api\InvalidElementTypeException;
@@ -47,6 +48,7 @@
 use Pimcore\Bundle\StudioBackendBundle\Util\Constant\ElementPermissions;
 use Pimcore\Bundle\StudioBackendBundle\Util\Constant\ElementTypes;
 use Pimcore\Bundle\StudioBackendBundle\Util\Constant\HttpResponseCodes;
+use Pimcore\Bundle\StudioBackendBundle\Util\Constant\HttpResponseErrorKeys;
 use Pimcore\Bundle\StudioBackendBundle\Util\Trait\ElementProviderTrait;
 use Pimcore\Bundle\StudioBackendBundle\Util\Trait\UserPermissionTrait;
 use Pimcore\Model\DataObject\AbstractObject;
@@ -89,6 +91,13 @@ public function __construct(
     ) {
     }
 
+    public function getDataObjectFullPath(
+        string $parentFullPath,
+        string $key
+    ): string {
+        return str_ends_with($parentFullPath, '/') === true ? $parentFullPath . $key : $parentFullPath . '/' . $key;
+    }
+
     /**
      * @throws DatabaseException
      * @throws ElementSavingFailedException
@@ -103,8 +112,15 @@ public function addDataObject(
     ): int {
         $user = $this->securityService->getCurrentUser();
         $parent = $this->getValidParent($user, $parentId);
-        if ($this->dataObjectServiceResolver->pathExists($parent->getFullPath() . '/' . $parameters->getKey())) {
-            throw new ElementSavingFailedException(null, 'Element with the same key and path already exists');
+        $fullPath = $this->getDataObjectFullPath(
+            $parent->getFullPath(),
+            $parameters->getKey()
+        );
+        if ($this->dataObjectServiceResolver->pathExists($fullPath)) {
+            throw new ElementExistsException(
+                $fullPath,
+                HttpResponseErrorKeys::ELEMENT_EXISTS->value
+            );
         }
 
         $class = $this->getValidClass($this->classDefinitionResolver, $parameters->getClassId());

src/DataObject/Service/DataObjectServiceInterface.php

@@ -99,4 +99,9 @@ public function getDataObjectElementByPath(
      * @throws ForbiddenException|InvalidQueryTypeException|NotFoundException|UserNotFoundException
      */
     public function setTreeSorting(DataObjectModel $parent, QueryInterface $dataObjectQuery): void;
+
+    public function getDataObjectFullPath(
+        string $parentFullPath,
+        string $key
+    ): string;
 }