Skip to content

Commit b8b9c7e

Browse files
committed
Merge branch '2026.1' into 2026.x
2 parents 706ce58 + 4d01778 commit b8b9c7e

4 files changed

Lines changed: 9 additions & 12 deletions

File tree

src/Workflow/Controller/ElementsController.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
use OpenApi\Attributes\Get;
1717
use Pimcore\Bundle\StudioBackendBundle\Controller\AbstractApiController;
18+
use Pimcore\Bundle\StudioBackendBundle\OpenApi\Attribute\Parameter\Path\ElementTypeParameter;
1819
use Pimcore\Bundle\StudioBackendBundle\OpenApi\Attribute\Parameter\Query\PageParameter;
1920
use Pimcore\Bundle\StudioBackendBundle\OpenApi\Attribute\Parameter\Query\PageSizeParameter;
2021
use Pimcore\Bundle\StudioBackendBundle\OpenApi\Attribute\Parameter\Query\StringParameter;
@@ -41,7 +42,7 @@ final class ElementsController extends AbstractApiController
4142
{
4243
use PaginatedResponseTrait;
4344

44-
private const string ROUTE = '/workflows/elements';
45+
private const string ROUTE = '/workflows/elements/{elementType}';
4546

4647
public function __construct(
4748
SerializerInterface $serializer,
@@ -63,9 +64,9 @@ public function __construct(
6364
summary: 'workflow_get_elements_summary',
6465
tags: [Tags::Workflows->name]
6566
)]
67+
#[ElementTypeParameter]
6668
#[StringParameter('workflowName', 'product_workflow', 'Workflow name')]
6769
#[StringParameter('stateName', 'in_review', 'Workflow state / place name', required: false)]
68-
#[StringParameter('elementType', 'asset', 'Element type (asset or data-object)', required: false)]
6970
#[PageParameter]
7071
#[PageSizeParameter(50)]
7172
#[SuccessResponse(
@@ -74,12 +75,14 @@ public function __construct(
7475
)]
7576
#[DefaultResponses([
7677
HttpResponseCodes::UNAUTHORIZED,
78+
HttpResponseCodes::FORBIDDEN,
7779
HttpResponseCodes::INTERNAL_SERVER_ERROR,
7880
])]
7981
public function getElements(
82+
string $elementType,
8083
#[MapQueryString] WorkflowElementsParameters $parameters = new WorkflowElementsParameters()
8184
): JsonResponse {
82-
$collection = $this->workflowElementsService->getElements($parameters);
85+
$collection = $this->workflowElementsService->getElements($parameters, $elementType);
8386

8487
return $this->getPaginatedCollection(
8588
$this->serializer,

src/Workflow/MappedParameter/WorkflowElementsParameters.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
public function __construct(
2424
private string $workflowName = '',
2525
private ?string $stateName = null,
26-
private ?string $elementType = null,
2726
private int $page = 1,
2827
private int $pageSize = 50,
2928
) {
@@ -39,11 +38,6 @@ public function getStateName(): ?string
3938
return $this->stateName;
4039
}
4140

42-
public function getElementType(): ?string
43-
{
44-
return $this->elementType;
45-
}
46-
4741
public function getPage(): int
4842
{
4943
return max(1, $this->page);

src/Workflow/Service/WorkflowElementsService.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function __construct(
4545
) {
4646
}
4747

48-
public function getElements(WorkflowElementsParameters $parameters): Collection
48+
public function getElements(WorkflowElementsParameters $parameters, string $elementType): Collection
4949
{
5050
$workflowName = $parameters->getWorkflowName();
5151
if ($workflowName === '') {
@@ -61,7 +61,7 @@ public function getElements(WorkflowElementsParameters $parameters): Collection
6161
$rows = $this->elementsRepository->fetchByWorkflowState(
6262
$workflowName,
6363
$stateName,
64-
$parameters->getElementType(),
64+
$elementType,
6565
);
6666

6767
[$stateLabel, $stateColor] = $stateName !== null && $stateName !== ''

src/Workflow/Service/WorkflowElementsServiceInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,5 @@ interface WorkflowElementsServiceInterface
2929
*
3030
* @return Collection<WorkflowElement>
3131
*/
32-
public function getElements(WorkflowElementsParameters $parameters): Collection;
32+
public function getElements(WorkflowElementsParameters $parameters, string $elementType): Collection;
3333
}

0 commit comments

Comments
 (0)