Skip to content

[Class definition]: Guess type based on the value of class definitions#1749

Merged
lukmzig merged 1 commit into2025.4from
3247-classdefinitions---problems-with-icon-saving
Apr 7, 2026
Merged

[Class definition]: Guess type based on the value of class definitions#1749
lukmzig merged 1 commit into2025.4from
3247-classdefinitions---problems-with-icon-saving

Conversation

@lukmzig
Copy link
Copy Markdown
Contributor

@lukmzig lukmzig commented Apr 7, 2026

Changes in this pull request

Resolves pimcore/studio-ui-bundle#3247

Additional info

  • As core class definitions supports only string for the values (there are no types) we need to guess the type basedo n this value in our class hydrator

@lukmzig lukmzig added this to the 2025.4 milestone Apr 7, 2026
@lukmzig lukmzig self-assigned this Apr 7, 2026
@lukmzig lukmzig changed the title guess type based on the value of class definitions [Class definition]: Guess type based on the value of class definitions Apr 7, 2026
@codacy-production
Copy link
Copy Markdown

Not up to standards ⛔

TIP This summary will be updated as you push new changes. Give us feedback

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 7, 2026

@lukmzig lukmzig requested a review from martineiber April 7, 2026 14:20
Copy link
Copy Markdown
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukmzig lukmzig merged commit 1728c17 into 2025.4 Apr 7, 2026
12 of 13 checks passed
@lukmzig lukmzig deleted the 3247-classdefinitions---problems-with-icon-saving branch April 7, 2026 15:23
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants