Skip to content

[Data Object Grid] Respect fallback languages for localized fields#1787

Merged
markus-moser merged 11 commits into2025.4from
fix/many-to-many-object-relation-fallback-language
Apr 29, 2026
Merged

[Data Object Grid] Respect fallback languages for localized fields#1787
markus-moser merged 11 commits into2025.4from
fix/many-to-many-object-relation-fallback-language

Conversation

@markus-moser
Copy link
Copy Markdown
Contributor

@markus-moser markus-moser commented Apr 27, 2026

Introduces the applyFallbackLanguages flag on the data object grid request body. When set to true, empty localized field values walk the configured fallback language chain (and fall back to the system default language as a last resort) instead of returning null.

The flag defaults to false so existing grid behaviour is completely unaffected. It is implemented via Pimcore's built-in Localizedfield::setGetFallbackValues() mechanism — no custom fallback chain logic.

Companion PR: pimcore/studio-ui-bundle#3424
Part of pimcore/studio-ui-bundle#3405

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 27, 2026

Not up to standards ⛔

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@markus-moser markus-moser force-pushed the fix/many-to-many-object-relation-fallback-language branch 3 times, most recently from 599e2a0 to dd926fc Compare April 28, 2026 14:20
@markus-moser markus-moser changed the title fix(grid): add fallback language support for many-to-many object relation visible columns fix: respect fallback languages for localized fields in data object grid Apr 28, 2026
@markus-moser markus-moser changed the title fix: respect fallback languages for localized fields in data object grid [Data Object Grid] Respect fallback languages for localized fields Apr 28, 2026
@markus-moser markus-moser force-pushed the fix/many-to-many-object-relation-fallback-language branch from dd926fc to 713ab60 Compare April 28, 2026 14:30
…solverInterface for consistency

Replace contract interfaces with non-contract versions to match the
existing pattern in studio-backend-bundle (e.g. WebsiteSettingsService,
LanguageService, ApiContextSubscriber).
@markus-moser markus-moser marked this pull request as ready for review April 28, 2026 14:56
@martineiber martineiber added this to the 2025.4.2 milestone Apr 28, 2026
Comment thread src/Grid/Column/Resolver/DataObject/AdapterResolver.php
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markus-moser markus-moser merged commit 6f3baaf into 2025.4 Apr 29, 2026
12 of 13 checks passed
@markus-moser markus-moser deleted the fix/many-to-many-object-relation-fallback-language branch April 29, 2026 11:51
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants