-
Notifications
You must be signed in to change notification settings - Fork 7
[Data Object Grid] Respect fallback languages for localized fields #1787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
markus-moser
merged 11 commits into
2025.4
from
fix/many-to-many-object-relation-fallback-language
Apr 29, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ed7fa2f
feat(grid): add applyFallbackLanguages parameter to grid endpoint
markus-moser d4dbb9c
fix: forward applyFallbackLanguages to sub-column in AdvancedColumnRe…
markus-moser 8b25786
fix: also fall back to system default language when configured fallba…
markus-moser 05ce686
refactor: use Localizedfield::setGetFallbackValues instead of manual …
markus-moser 5036240
fix: revert to manual fallback chain including system default language
markus-moser cc5c7da
fix: move applyFallbackLanguages from request body to per-column
markus-moser 713ab60
fix: respect fallback languages for localized fields in data object grid
markus-moser 940718c
refactor: use non-contract ToolResolverInterface and LocalizedFieldRe…
markus-moser 5cdb85d
refactor: add #[Override] attribute to trait method implementations
markus-moser e8cd2fb
revert: remove #[Override] attribute — not applicable for trait abstr…
markus-moser 1ccef8d
docs: add @see annotations to trait method overrides for clarity
markus-moser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| <?php | ||
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * This source file is available under the terms of the | ||
| * Pimcore Open Core License (POCL) | ||
| * Full copyright and license information is available in | ||
| * LICENSE.md which is distributed with this source code. | ||
| * | ||
| * @copyright Copyright (c) Pimcore GmbH (https://www.pimcore.com) | ||
| * @license Pimcore Open Core License (POCL) | ||
| */ | ||
|
|
||
| namespace Pimcore\Bundle\StudioBackendBundle\Grid\Attribute\Request; | ||
|
|
||
| use Attribute; | ||
| use OpenApi\Attributes\Items; | ||
| use OpenApi\Attributes\JsonContent; | ||
| use OpenApi\Attributes\Property; | ||
| use OpenApi\Attributes\RequestBody; | ||
| use Pimcore\Bundle\StudioBackendBundle\Grid\Schema\Column; | ||
| use Pimcore\Bundle\StudioBackendBundle\Grid\Schema\Filter; | ||
| use Pimcore\Bundle\StudioBackendBundle\OpenApi\Attribute\Property\SingleInteger; | ||
|
|
||
| /** | ||
| * @internal | ||
| */ | ||
| #[Attribute(Attribute::TARGET_METHOD)] | ||
| final class DataObjectGridRequestBody extends RequestBody | ||
| { | ||
| public function __construct() | ||
| { | ||
| parent::__construct( | ||
| required: true, | ||
| content: new JsonContent( | ||
| required: ['folderId'], | ||
| properties: [ | ||
| new SingleInteger(propertyName: 'folderId'), | ||
| new Property( | ||
| property: 'applyFallbackLanguages', | ||
| description: 'When true, empty localized values fall back to configured fallback languages', | ||
| type: 'boolean', | ||
| default: false | ||
| ), | ||
| new Property( | ||
| property: 'columns', | ||
| type: 'array', | ||
| items: new Items(ref: Column::class) | ||
| ), | ||
| new Property( | ||
| property: 'filters', | ||
| ref: Filter::class, | ||
| type: 'object' | ||
| ), | ||
| ], | ||
| type: 'object', | ||
| ), | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.