[Assets] Add video thumbnail status endpoint for Studio polling#1810
Merged
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 critical |
| CodeStyle | 18 minor |
🟢 Metrics 5 complexity
Metric Results Complexity 5
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Studio needs a way to detect when an inprogress video thumbnail
finishes converting so it can refresh the editor automatically.
Today the only consumer of the thumbnail status is BinaryService,
which uses it internally to decide whether to stream or throw
ElementProcessingNotCompletedException - it isn't exposed to clients.
Adds GET /pimcore-studio/api/assets/{id}/video/thumbnail/{thumbnailName}/status
returning {status: finished | inprogress | error | not_started}.
studio-ui-bundle polls this endpoint while a Video editable is in
the in-progress state and reloads the editor when conversion finishes.
Resolves pimcore/studio-ui-bundle#3407
markus-moser
force-pushed
the
3407-fix-video-thumbnail-status-endpoint
branch
from
49f7109 to
d1edb64
Compare
|
This was referenced May 5, 2026
Merged
…nd unit test - VideoService::getThumbnailStatus() now reads the status from the asset's 'thumbnails' custom setting instead of calling Asset\Video::getThumbnail(): getThumbnail() starts a conversion as a side effect (a GET endpoint should be read-only) and returns null for errored conversions, which made the 'error' status unreachable and left polling clients spinning forever - add the missing studio_api_docs.en.yaml entries for the new endpoint - add a unit test for the status mapping
|
lukmzig
approved these changes
Jun 16, 2026
markus-moser
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves pimcore/studio-ui-bundle#3407
Adds
GET /pimcore-studio/api/assets/{id}/video/thumbnail/{thumbnailName}/statusreturning{status: finished | inprogress | error | not_started}.studio-ui-bundle polls this while a Video editable is in the in-progress state and reloads the editor when conversion finishes. No existing endpoint exposes this —
BinaryServiceonly uses the status internally to decide between streaming and throwingElementProcessingNotCompletedException.Additional info
Companion PRs:
🚧 Draft pending the companion PRs above.