[BUG] Gate open and remove actions in relation tables on element permissions#1872
Open
Jonathon-Meney-Torq wants to merge 1 commit into
Open
[BUG] Gate open and remove actions in relation tables on element permissions#1872Jonathon-Meney-Torq wants to merge 1 commit into
Jonathon-Meney-Torq wants to merge 1 commit into
Conversation
Not up to standards ⛔
|
ce33908 to
27f2f13
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
hasAccessandcanEditboolean flags toRelatedElementDataschemaElementDataService::getRelatedElementData()computes per-element access using classic adminAbstractElement::isAllowed()—hasAccessfromviewpermission on the related element,canEditfromsaveorpublishpermission on the parent objectRelationNormalizationContextservice to pass the parentConcreteobject intoElementDataServiceduring normalization without changing interface signaturesDataService::getDetailObjectData()sets and clears the context via try/finallyGridSearch::searchElementsForUser()skips workspace path and user restrictions when the request is asystem.idsfilter query, so custom field columns load for relation items regardless of workspace accessElementProviderTrait::getElementType()visibility changed fromprivatetoprotectedto allow subclassing