Skip to content

[BUG] Gate open and remove actions in relation tables on element permissions#1872

Open
Jonathon-Meney-Torq wants to merge 1 commit into
pimcore:2025.4from
TorqIT:feature/relation-table-visibility
Open

[BUG] Gate open and remove actions in relation tables on element permissions#1872
Jonathon-Meney-Torq wants to merge 1 commit into
pimcore:2025.4from
TorqIT:feature/relation-table-visibility

Conversation

@Jonathon-Meney-Torq

Copy link
Copy Markdown

Summary

  • Added hasAccess and canEdit boolean flags to RelatedElementData schema
  • ElementDataService::getRelatedElementData() computes per-element access using classic admin AbstractElement::isAllowed()hasAccess from view permission on the related element, canEdit from save or publish permission on the parent object
  • Introduced RelationNormalizationContext service to pass the parent Concrete object into ElementDataService during normalization without changing interface signatures
  • DataService::getDetailObjectData() sets and clears the context via try/finally
  • GridSearch::searchElementsForUser() skips workspace path and user restrictions when the request is a system.ids filter query, so custom field columns load for relation items regardless of workspace access
  • ElementProviderTrait::getElementType() visibility changed from private to protected to allow subclassing

@codacy-production

codacy-production Bot commented Jun 8, 2026

Copy link
Copy Markdown

Not up to standards ⛔

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@Jonathon-Meney-Torq Jonathon-Meney-Torq changed the title [ENHANCEMENT] Gate open and remove actions in relation tables on element permissions [BUG] Gate open and remove actions in relation tables on element permissions Jun 8, 2026
@Jonathon-Meney-Torq Jonathon-Meney-Torq changed the base branch from 2026.x to 2025.4 June 8, 2026 14:27
@Jonathon-Meney-Torq Jonathon-Meney-Torq force-pushed the feature/relation-table-visibility branch from ce33908 to 27f2f13 Compare June 8, 2026 14:38
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
2 New Major Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant