Skip to content

[Search] [Data Objects] Search Endpoint#918

Merged
martineiber merged 7 commits into1.xfrom
892-data-object-search
Mar 19, 2025
Merged

[Search] [Data Objects] Search Endpoint#918
martineiber merged 7 commits into1.xfrom
892-data-object-search

Conversation

@martineiber
Copy link
Copy Markdown
Contributor

Changes in this pull request

Resolves #892

Additional info

@martineiber martineiber self-assigned this Mar 19, 2025
@martineiber martineiber marked this pull request as ready for review March 19, 2025 08:42
@martineiber martineiber requested review from lukmzig and mattamon March 19, 2025 08:42
Copy link
Copy Markdown
Contributor

@lukmzig lukmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Only thing I am not competely sure is the TAG itself, based on the original issue:
pimcore/studio-ui-bundle#245

I created a search tag (namespace), the idea was that this one will have all searches, currently it contains the generic search and search previews based on the element types. Not sure if specific search should be there based on the element type as well or rather under specific element namespace.

@martineiber
Copy link
Copy Markdown
Contributor Author

LGTM

Only thing I am not competely sure is the TAG itself, based on the original issue: pimcore/studio-ui-bundle#245

I created a search tag (namespace), the idea was that this one will have all searches, currently it contains the generic search and search previews based on the element types. Not sure if specific search should be there based on the element type as well or rather under specific element namespace.

Good Point! Did not see that.
I will move all new endpoints to that tag

@martineiber martineiber requested a review from lukmzig March 19, 2025 09:04
@sonarqubecloud
Copy link
Copy Markdown

@martineiber martineiber merged commit f6e69b0 into 1.x Mar 19, 2025
12 checks passed
@martineiber martineiber deleted the 892-data-object-search branch March 19, 2025 09:48
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Search] [Data Objects] Search Endpoint

2 participants