Clean up storybook stories design and UX#3828
Open
idaiv wants to merge 6 commits into
Open
Conversation
Stories: - Remove WithPreview variant from Image stories - Delete ImagePreview, ImageZoom, Empty and Media (PimcoreImage/Audio/Video/Document) stories - Move ImageZoom as ImageZoomExample variant into ButtonGroup stories - Remove LeftAligned and RightAligned variants from Toolbar stories - Remove HorizontalForm variant from Form stories - Move InputModal stories from Data Entry to Feedback category - Add CircularSuccess/Reject custom icons and Scores variant to Progress stories Icons: - Add close-outline, info-outline, question-mark-outline, check SVGs and register in icon library AlertModal: - Replace Ant Design default icons with Pimcore icons per type (info/error/warn/success) - Add OK button text via alert-modal.ok-text translation key Translations (en/de/es/fr/it/no/sv): - Add missing success key - Add alert-modal.ok-text: OK Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…breaks Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #https://github.com/pimcore/product-management/issues/1281
Additional info
Stories — Removed / Cleaned Up
WithPreviewstory variantPimcoreImage,PimcoreDocument,PimcoreVideo,PimcoreAudio) and the folderLeftAlignedandRightAlignedstory variantsHorizontalFormstory variantStories — Reorganised
Components/Data Entry→Components/Feedback, matching all other modalsStories — New / Updated
ImageZoomExamplestory variant (replaces the standalone ImageZoom story)CircularSuccessandCircularRejectvariants using custom Pimcore icons (check,close) at 38×38px withcolorSuccess/colorErrortokensScoresvariant using DQM-inspired horizontal progress bars with the correct Studio UI default color palette (A–D grades)InputandInputWithInitialValuevariants: primary button renamed to ConfirmConfirmationvariant: Pimcorealerticon at 22×22px, primary = Confirm, secondary = DiscardIcon Library — New Icons Added
Four new SVG icons registered in the icon library (
Name | File -- | -- close-outline | close-outline.inline.svg info-outline | info-outline.inline.svg question-mark-outline | question-mark-outline.inline.svg check | check.inline.svgindex.ts):check.inline.svgusesfill="currentColor"so it correctly inherits color from CSS.Alert Modal — Icons & Button Text
info→ Pimcoreinfoiconerror→ Pimcoreclose-fillediconwarn→ Pimcorealerticonsuccess→ Pimcorecheckmarkiconalert-modal.ok-text)Translations — 7 Language Files Updated
Added two new keys across
en,de,es,fr,it,no,sv:success:— translated per languagealert-modal.ok-text: OK— same in all languages