[Bug] Fix progress bar for batched tag and rewrite-references jobs#3637
Merged
Conversation
The backend now batches tag assign/replace and element reference rewrites into chunks of 500, each step streaming progress 0–100. Both jobs used the handler default ProgressFieldCalculator with DefaultStepTracker (no step context), so the bar reset between batches. Wire both AbstractBatchEditJob (covers studio_ee_job_patch_elements and studio_ee_job_rewrite_element_references) and TagAssignJob to the existing BatchedStepProgressCalculator.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
The backend now batches tag assign/replace and element reference rewrites into chunks of 500 (pimcore/studio-backend-bundle#1815), so their progress bars reset between batches — same root cause as the delete fix.
Wire
AbstractBatchEditJob(coversstudio_ee_job_patch_elementsandstudio_ee_job_rewrite_element_references) andTagAssignJobtoBatchedStepProgressCalculator.Additional info
Depends on pimcore/studio-backend-bundle#1815. No API/schema change.