[Documents] Keep EditableOverlay root stable to avoid duplicated editables on highlight#3812
Open
ValeriaMaltseva wants to merge 5 commits into
Open
[Documents] Keep EditableOverlay root stable to avoid duplicated editables on highlight#3812ValeriaMaltseva wants to merge 5 commits into
ValeriaMaltseva wants to merge 5 commits into
Conversation
markus-moser
requested changes
Jun 29, 2026
| const highlightEditables = useHighlightEditables() | ||
| const { inheritanceMenuItems, inheritanceTooltip } = useInheritanceMenu({ onOverwrite }) | ||
|
|
||
| const wasEverInheritedRef = useRef(isInherited) |
Contributor
There was a problem hiding this comment.
Hm... But isn't then the inheritance overlay case also editable? I guess we need to find another solution?
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
Done — I resolved the merge conflicts by merging |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #3390