fix: avoid bigint exponentiation for Turbopack compatibility#504
Open
skyc1e wants to merge 1 commit into
Open
Conversation
|
skyc1e
force-pushed
the
fix/turbopack-bigint-exponentiation
branch
from
92a791d to
be651b5
Compare
Replace `10n ** 18n` and `BigInt(1e18)` with `1_000_000_000_000_000_000n`
in estimateErc20PaymasterCost.
`10n ** 18n` crashes Turbopack ("right-associative binary expression
not yet implemented"). `BigInt(1e18)` passes through a Number first,
which is technically imprecise for values near MAX_SAFE_INTEGER.
A bigint literal avoids both problems.
Closes pimlicolabs#499
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
10n ** 18nandBigInt(1e18)with1_000_000_000_000_000_000ninestimateErc20PaymasterCost.Two problems in the original code:
10n ** 18ncrashes Turbopack — it doesn't support the**operator with bigint operands yet ("right-associative binary expression not yet implemented").BigInt(1e18)on the adjacent line converts a Number to BigInt;1e18is at the edge ofNumber.MAX_SAFE_INTEGERand the pattern is imprecise in general.A bigint literal avoids both issues. Low risk: replaces a bigint exponent expression and a Number-to-BigInt cast with an equivalent bigint literal, avoiding the Turbopack parser limitation without changing the computed value.
Closes #499