Add local QA helpers and python 3.13/trixie support#20
Open
dannystaple wants to merge 11 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a Docker-based local QA environment with a pinned dependency lockfile, documentation for running checks in the container, and tweaks the existing tox and check.sh setup to better support isolated testing.
Changes:
- New
Dockerfile.testing+requirements-dev.lockproviding a reproducible dev/test image driven byuv. - New
LOCAL_QA.mddocumenting how to build and run QA targets inside the container. tox.iniswitched toskip_install+ manualpip install --no-depsto avoid pulling hardware-specific deps;check.shexportsTERM.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Dockerfile.testing | New image: uv + Python 3.11, system tools, non-root appuser, installs from lockfile. |
| requirements-dev.lock | New uv-generated lockfile pinning all dev deps for Python 3.11. |
| LOCAL_QA.md | New docs describing build/run commands and lockfile regeneration. |
| tox.ini | Skips install and instead does pip install --no-deps in commands_pre; also skip_install for qa. |
| check.sh | Exports TERM so subprocesses inherit the value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Whew, thank you, might take me a while to get to this since I'm buried in Pico stuff at the moment. I also really ought to play with uv more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of pimoroni/inventorhatmini-python#16 to the boilerplate.
A couple of whys
Mostly Developer Experience (devx) to make fixing the ci failures a bit easier.
Testing