Skip to content

master: optimizer: update default value of fix control 52869#21743

Merged
ti-chi-bot[bot] merged 7 commits into
pingcap:masterfrom
time-and-fate:doc-optfix-52869-default-master
Jul 7, 2026
Merged

master: optimizer: update default value of fix control 52869#21743
ti-chi-bot[bot] merged 7 commits into
pingcap:masterfrom
time-and-fate:doc-optfix-52869-default-master

Conversation

@time-and-fate

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Update the default value description of optimizer fix control 52869 to clarify that it is ON starting from TiDB v8.5.7.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2026
@qiancai qiancai changed the title optimizer: update default value of fix control 52869 master: optimizer: update default value of fix control 52869 Jun 25, 2026
Comment thread optimizer-fix-controls.md Outdated
@qiancai qiancai self-assigned this Jun 25, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

@qw4990: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai qiancai added the v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3. label Jul 2, 2026
Update optimizer-fix-controls.md and explain-index-merge.md to describe the ON/OFF behavior of 52869 and the v8.5.7 default value change, replacing the previous 'limitation exists by default' wording.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Comment thread explain-index-merge.md Outdated
Comment thread optimizer-fix-controls.md Outdated
Co-authored-by: Grace Cai <qqzczy@126.com>
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 6, 2026
Comment thread explain-index-merge.md Outdated
Comment thread optimizer-fix-controls.md Outdated
@ti-chi-bot ti-chi-bot Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2026
@qiancai qiancai force-pushed the doc-optfix-52869-default-master branch from 7d740c7 to 25b3c79 Compare July 7, 2026 01:37
@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 7, 2026
Comment thread explain-index-merge.md Outdated
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 7, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-07-07 02:27:42.786624989 +0000 UTC m=+75848.822720066: ☑️ agreed by qiancai.

Comment thread explain-index-merge.md Outdated
@qiancai

qiancai commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

/approve

@qiancai qiancai added the lgtm label Jul 7, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 7, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 470dbd6 into pingcap:master Jul 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants