Skip to content

test: update sql-statement-change-column#13733

Closed
qiancai wants to merge 2 commits into
pingcap:masterfrom
qiancai:establish_sql_statement-13817
Closed

test: update sql-statement-change-column#13733
qiancai wants to merge 2 commits into
pingcap:masterfrom
qiancai:establish_sql_statement-13817

Conversation

@qiancai

@qiancai qiancai commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

What is changed, added or deleted? (Required)

  • Update the format of usage section: add more description about SQL statements, remove "Query OK", and move some examples to "Compatibility with MySQL"
  • Update the limitation of "ERROR 1105 (HY000): can't run multi schema change". In TiDB v5.0, tidb_enable_change_multi_schema is introduced to run multiple schema change and TiDB v6.2.0 supports multiple schema change by default.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)

What is the related PR or file link(s)?

looks so strange...
image

@ti-chi-bot

ti-chi-bot Bot commented Jun 1, 2023

Copy link
Copy Markdown

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@qiancai qiancai added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-6.1 needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. type/enhancement The issue or PR belongs to an enhancement. labels Jun 1, 2023
@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 1, 2023
@qiancai

qiancai commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator Author

close this test PR

@qiancai qiancai closed this Jun 1, 2023
@qiancai qiancai changed the title sql-statement: update sql-statement-change-column test: update sql-statement-change-column Jun 1, 2023
@qiancai
qiancai deleted the establish_sql_statement-13817 branch June 1, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant