Skip to content

tidb: add description for var tidb_ddl_reorg_max_write_speed#19445

Merged
ti-chi-bot[bot] merged 7 commits intopingcap:masterfrom
CbcWestwolf:ddl_ingest_write_limit
Nov 26, 2024
Merged

tidb: add description for var tidb_ddl_reorg_max_write_speed#19445
ti-chi-bot[bot] merged 7 commits intopingcap:masterfrom
CbcWestwolf:ddl_ingest_write_limit

Conversation

@CbcWestwolf
Copy link
Copy Markdown
Member

@CbcWestwolf CbcWestwolf commented Nov 18, 2024

What is changed, added or deleted? (Required)

add description for var tidb_ddl_reorg_max_write_speed

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 18, 2024
@qiancai qiancai self-requested a review November 18, 2024 06:27
@qiancai qiancai added v8.5 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Nov 18, 2024
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Nov 18, 2024
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 18, 2024
qiancai
qiancai reviewed Nov 18, 2024
View reviewed changes
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
@CbcWestwolf @qiancai
Apply suggestions from code review
65842fe 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 18, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Nov 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-18 06:44:18.956435401 +0000 UTC m=+857021.147304394: ☑️ agreed by tangenta.
  • 2024-11-18 07:33:07.975738196 +0000 UTC m=+859950.166607190: ☑️ agreed by qiancai.

@qiancai qiancai self-assigned this Nov 18, 2024
@hfxsd hfxsd mentioned this pull request Nov 18, 2024
Merged
17 tasks
@Oreoxmt Oreoxmt self-requested a review November 19, 2024 01:03
Oreoxmt
Oreoxmt reviewed Nov 19, 2024
View reviewed changes
Comment thread system-variables.md Outdated
Oreoxmt
Oreoxmt approved these changes Nov 19, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

CbcWestwolf and others added 3 commits November 19, 2024 16:18
@CbcWestwolf @Oreoxmt
Update system-variables.md
3a708d4 
Co-authored-by: Aolin <aolinz@outlook.com>
@CbcWestwolf
update
f949117
@CbcWestwolf
update
115ddb8
qiancai
qiancai reviewed Nov 25, 2024
View reviewed changes
Comment thread system-variables.md Outdated
qiancai
qiancai reviewed Nov 26, 2024
View reviewed changes
Comment thread system-variables.md Outdated
@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented Nov 26, 2024

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Nov 26, 2024
@ti-chi-bot ti-chi-bot Bot merged commit 445741d into pingcap:master Nov 26, 2024
@CbcWestwolf CbcWestwolf deleted the ddl_ingest_write_limit branch November 28, 2024 07:41
@CbcWestwolf
Copy link
Copy Markdown
Member Author

CbcWestwolf commented Dec 10, 2024

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Dec 10, 2024

@CbcWestwolf: new pull request created to branch release-7.5: #19643.

Details

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 10, 2024
Merged
16 tasks
@CbcWestwolf
Copy link
Copy Markdown
Member Author

CbcWestwolf commented Dec 10, 2024

/cherry-pick release-6.5
/cherry-pick release-7.1
/cherry-pick release-8.1

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Dec 10, 2024

@CbcWestwolf: new pull request created to branch release-6.5: #19644.

Details

In response to this:

/cherry-pick release-6.5
/cherry-pick release-7.1
/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 10, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Dec 10, 2024

@CbcWestwolf: new pull request created to branch release-7.1: #19645.

Details

In response to this:

/cherry-pick release-6.5
/cherry-pick release-7.1
/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 10, 2024
Open
16 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Dec 10, 2024

@CbcWestwolf: new pull request created to branch release-8.1: #19646.

Details

In response to this:

/cherry-pick release-6.5
/cherry-pick release-7.1
/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 10, 2024
Open
16 tasks
ti-chi-bot Bot pushed a commit that referenced this pull request Dec 31, 2024
@ti-chi-bot
v7.5.5 tidb: add description for var tidb_ddl_reorg_max_write_speed (…
575df9e 
…#19445) (#19643)
ti-chi-bot Bot pushed a commit that referenced this pull request Feb 27, 2025
@ti-chi-bot
v6.5.12: tidb: add description for var `tidb_ddl_reorg_max_write_spee…
ba1daea 
…d` (#19445) (#19644)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiancai qiancai qiancai approved these changes

@tangenta tangenta tangenta approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@qiancai qiancai

Labels

approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CbcWestwolf @qiancai @ti-chi-bot @tangenta @Oreoxmt