docs: add documentation for ADMIN ALTER DDL JOBS command by tangenta · Pull Request #19492 · pingcap/docs

tangenta · 2024-11-22T07:50:46Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

What is the related PR or file link(s)?

This PR is translated from: docs: add documentation for ADMIN ALTER DDL JOBS command docs-cn#19085
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2024-11-22T08:41:51Z

@fzzf678: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

Frank945946 · 2024-12-02T02:36:22Z

-    - `BATCH_SIZE`: the batch size. The initial value is set by [`tidb_ddl_reorg_batch_size`](/system-variables.md#tidb_ddl_reorg_batch_size).
-    - `MAX_WRITE_SPEED`: the maximum bandwidth limit for importing index records into each TiKV. The initial value is set by [`tidb_ddl_reorg_max_write_speed`](/system-variables.md#tidb_ddl_reorg_max_write_speed-new-in-v850).
+    - `BATCH_SIZE`: the batch size. You can set the initial value by [`tidb_ddl_reorg_batch_size`](/system-variables.md#tidb_ddl_reorg_batch_size).
+    - `MAX_WRITE_SPEED`: the maximum bandwidth limit for importing index records into each TiKV. The initial value is set by [`tidb_ddl_reorg_max_write_speed`](/system-variables.md#tidb_ddl_reorg_max_write_speed-new-in-v850). Currently this parameter only works for jobs with `ADD INDEX` submitted and running after disabling [`tidb_enable_dist_task`](/system-variables.md#tidb_enable_dist_task-new-in-v710).


Suggested change

- `MAX_WRITE_SPEED`: the maximum bandwidth limit for importing index records into each TiKV. The initial value is set by [`tidb_ddl_reorg_max_write_speed`](/system-variables.md#tidb_ddl_reorg_max_write_speed-new-in-v850). Currently this parameter only works for jobs with `ADD INDEX` submitted and running after disabling [`tidb_enable_dist_task`](/system-variables.md#tidb_enable_dist_task-new-in-v710).

- `MAX_WRITE_SPEED`: the maximum bandwidth limit for importing index records into each TiKV. The initial value is set by [`tidb_ddl_reorg_max_write_speed`](/system-variables.md#tidb_ddl_reorg_max_write_speed-new-in-v850).

Currently, the above parameters only work for jobs with `ADD INDEX` submitted and running after disabling [`tidb_enable_dist_task`](/system-variables.md#tidb_enable_dist_task-new-in-v710).

ti-chi-bot · 2024-12-02T02:36:58Z

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2024-12-02T02:37:28Z

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lilin90

/lgtm

ti-chi-bot · 2024-12-02T06:52:30Z

[LGTM Timeline notifier]

Timeline:

2024-12-02 06:28:07.945433634 +0000 UTC m=+1049875.565088150: ☑️ agreed by lilin90.
2024-12-02 06:52:29.102945631 +0000 UTC m=+1051336.722600142: ☑️ agreed by hfxsd.

hfxsd · 2024-12-02T06:53:29Z

/approve

ti-chi-bot · 2024-12-02T06:53:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [hfxsd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-12-02T06:57:49Z

In response to a cherrypick label: new pull request created to branch release-8.5: #19546.

…9546)

docs: add documentation for ADMIN ALTER DDL JOBS command

18afd37

ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2024

hfxsd self-assigned this Nov 22, 2024

hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.5 and removed missing-translation-status This PR does not have translation status info. labels Nov 22, 2024

hfxsd self-requested a review November 22, 2024 07:52

fzzf678 approved these changes Nov 22, 2024

View reviewed changes

hfxsd added 2 commits November 22, 2024 18:01

Update TOC.md

b753d92

Update sql-statement-admin-alter-ddl.md

f8ba311

hfxsd reviewed Nov 25, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-show-ddl.md Outdated

hfxsd reviewed Nov 25, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-show-ddl.md Outdated

tangenta and others added 2 commits November 25, 2024 13:43

Update sql-statements/sql-statement-admin-show-ddl.md

4de1d6e

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

Update sql-statements/sql-statement-admin-show-ddl.md

b9e1679

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

tangenta commented Nov 25, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

Update sql-statements/sql-statement-admin-alter-ddl.md

6823bb0

hfxsd requested a review from lilin90 November 25, 2024 06:45

hfxsd reviewed Nov 28, 2024

View reviewed changes

Comment thread TOC.md Outdated

hfxsd reviewed Nov 28, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-show-ddl.md Outdated

Apply suggestions from code review

09e4e7f

hfxsd reviewed Nov 28, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

Update sql-statements/sql-statement-admin-alter-ddl.md

722b394

hfxsd reviewed Nov 29, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

hfxsd reviewed Nov 29, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-show-ddl.md Outdated

hfxsd reviewed Nov 29, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-show-ddl.md Outdated

Apply suggestions from code review

47cc83a

hfxsd reviewed Dec 2, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-alter-ddl.md

hfxsd reviewed Dec 2, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-show-ddl.md Outdated

Frank945946 approved these changes Dec 2, 2024

View reviewed changes

hfxsd reviewed Dec 2, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

hfxsd reviewed Dec 2, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-show-ddl.md Outdated

hfxsd reviewed Dec 2, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-show-ddl.md Outdated

Apply suggestions from code review

7521a93

hfxsd reviewed Dec 2, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

hfxsd and others added 2 commits December 2, 2024 10:48

Apply suggestions from code review

ff3c547

Update format

85b6567

lilin90 reviewed Dec 2, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

lilin90 reviewed Dec 2, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

Apply suggestions from code review

228ffdf

hfxsd added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 2, 2024

lilin90 added 2 commits December 2, 2024 14:24

Refine wording and format

0eda3df

Update wording

e540032

lilin90 approved these changes Dec 2, 2024

View reviewed changes

ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 2, 2024

hfxsd approved these changes Dec 2, 2024

View reviewed changes

ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 2, 2024

ti-chi-bot Bot added the approved label Dec 2, 2024

ti-chi-bot Bot merged commit 9184833 into pingcap:master Dec 2, 2024

ti-chi-bot mentioned this pull request Dec 2, 2024

docs: add documentation for ADMIN ALTER DDL JOBS command (#19492) #19546

Merged

17 tasks

ti-chi-bot Bot pushed a commit that referenced this pull request Dec 2, 2024

docs: add documentation for ADMIN ALTER DDL JOBS command (#19492) (#1…

0ca146a

…9546)

	- `MAX_WRITE_SPEED`: the maximum bandwidth limit for importing index records into each TiKV. The initial value is set by [`tidb_ddl_reorg_max_write_speed`](/system-variables.md#tidb_ddl_reorg_max_write_speed-new-in-v850). Currently this parameter only works for jobs with `ADD INDEX` submitted and running after disabling [`tidb_enable_dist_task`](/system-variables.md#tidb_enable_dist_task-new-in-v710).
	- `MAX_WRITE_SPEED`: the maximum bandwidth limit for importing index records into each TiKV. The initial value is set by [`tidb_ddl_reorg_max_write_speed`](/system-variables.md#tidb_ddl_reorg_max_write_speed-new-in-v850).
	Currently, the above parameters only work for jobs with `ADD INDEX` submitted and running after disabling [`tidb_enable_dist_task`](/system-variables.md#tidb_enable_dist_task-new-in-v710).

Conversation

tangenta commented Nov 22, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

ti-chi-bot Bot commented Nov 22, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frank945946 Dec 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot Bot commented Dec 2, 2024

Uh oh!

ti-chi-bot Bot commented Dec 2, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lilin90 left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot Bot commented Dec 2, 2024

[LGTM Timeline notifier]

Uh oh!

hfxsd commented Dec 2, 2024

Uh oh!

ti-chi-bot Bot commented Dec 2, 2024

Uh oh!

ti-chi-bot commented Dec 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Frank945946 Dec 2, 2024 •

edited

Loading